Re: [PATCH 1/2] Make xencommons a bit more idiomatic

[Jeremy Fitzhardinge <jeremy@goop.org>]

On 08/30/2011 09:41 AM, Ian Jackson wrote:
> Jeremy Fitzhardinge writes ("[Xen-devel] [PATCH 1/2] Make xencommons a bit more idiomatic"):
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ...
>> -if test "x$1" = xstart && \
>> -     test -d /proc/xen && \
>> -   ! test -f /proc/xen/capabilities && \
>> -   ! grep '^xenfs ' /proc/mounts >/dev/null;
>> -then
>> +if [ "x$1" = xstart -a -d /proc/xen -a \
>> +    ! -f /proc/xen/capabilities ] && \
>> +    ! grep -qw '^xenfs' /proc/mounts; then
>>  	mount -t xenfs xenfs /proc/xen
> I'm afraid I'm reluctant to accept this purely stylistic change.  I
> might if it seemed to me to be a clear improvement, but I don't think
> that's the case.
>
> If anything we should be moving towards the use of && rather than -a,
> as that is harmless and will make the script depend less on /bin/bash.

No, you've misread it.  I'm changing it to use test for all the
file-existence checks in it's idiomatic form of '[', which implements
-a.  It is not at all bash-specific.

    J