From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C structures
Date: Tue, 30 Aug 2011 20:29:16 +0200 [thread overview]
Message-ID: <4E5D2BFC.2090401@redhat.com> (raw)
In-Reply-To: <CAAu8pHu9nPQdaENGpmJaVPZDp-tk58Zcg_52z7jhAr4YkJtYiw@mail.gmail.com>
On 08/30/2011 07:57 PM, Blue Swirl wrote:
>> >
>> > +#if defined(_WIN32)
>> > +# define QEMU_PACKED __attribute__((gcc_struct, packed))
> Maybe we could also use gcc_struct also for non-win32?
>
>> > +#else
>> > +# define QEMU_PACKED __attribute__((packed))
>> > +#endif
Indeed.
Paolo
next prev parent reply other threads:[~2011-08-30 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 20:43 [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C structures Stefan Weil
2011-08-28 20:47 ` Andreas Färber
2011-08-29 5:12 ` Stefan Weil
2011-08-30 17:57 ` Blue Swirl
2011-08-30 18:29 ` Paolo Bonzini [this message]
2011-08-30 20:17 ` Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 2/7] block/vvfat: Fix packing for w32 Stefan Weil
2011-08-29 8:09 ` Kevin Wolf
2011-08-28 20:43 ` [Qemu-devel] [PATCH 3/7] acpi: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 4/7] hpet: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 5/7] usb: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 6/7] virtio: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 7/7] slirp: " Stefan Weil
2011-08-29 10:12 ` Jan Kiszka
2011-08-29 18:22 ` Stefan Weil
2011-08-29 21:15 ` Jan Kiszka
2011-08-28 21:43 ` [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields Blue Swirl
2011-08-29 5:01 ` Stefan Weil
2011-08-29 7:19 ` Gerd Hoffmann
2011-08-29 8:34 ` TeLeMan
2011-08-29 9:39 ` Alexander Graf
2011-08-29 19:55 ` Stefan Weil
2011-08-30 7:44 ` Kevin Wolf
2011-08-30 17:25 ` Stefan Weil
2011-08-30 18:29 ` Alexander Graf
2011-08-30 19:57 ` Blue Swirl
2011-08-31 7:40 ` Kevin Wolf
2011-08-31 10:37 ` [Qemu-devel] [PATCH 0/2] Fix packing for MinGW with new macro QEMU_PACKED Stefan Weil
2011-09-03 21:12 ` Blue Swirl
2011-08-31 10:38 ` [Qemu-devel] [PATCH 1/2] Add new macro QEMU_PACKED for packed C structures Stefan Weil
2011-08-31 10:38 ` [Qemu-devel] [PATCH 2/2] Use new macro QEMU_PACKED for packed structures Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5D2BFC.2090401@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.