From: Rob Evers <revers@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] alua: clarify messages when blk_execute_rq fails
Date: Tue, 30 Aug 2011 21:12:47 -0400 [thread overview]
Message-ID: <4E5D8A8F.6000104@redhat.com> (raw)
In-Reply-To: <1314740248.7613.1.camel@dabdike.conference.net>
On 08/30/2011 05:37 PM, James Bottomley wrote:
> On Tue, 2011-08-30 at 16:07 -0400, Rob Evers wrote:
>> On 08/12/2011 05:01 PM, Rob Evers wrote:
>>> replace numeric messages with string error messages when blk_execute_rq
>>> fails. Also add printing of sense info.
>>>
>>> Mike Christie suggested adding printing of sense info here
>>>
>>> Signed-off-by: Rob Evers<revers@redhat.com>
>>>
>> Hi James,
>>
>> Do you have any feedback on these patches?
>>
>> (I already noticed the 2nd patch is a reply to the first)
>>
>> I didn't see them in the last update of scsi-misc.
> I don't really see any point in removing messages.
"Unhandled error/sense code" can be interpreted as something going
wrong when nothing actually went wrong.
For lack of ideas that were accurate, yet not alarming, removing the
message
altogether seemed like the right option.
next prev parent reply other threads:[~2011-08-31 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 21:01 [PATCH 1/2] alua: clarify messages when blk_execute_rq fails Rob Evers
2011-08-12 21:01 ` [PATCH 2/2] scsi_io_completion: remove confusing unhandled messages Rob Evers
2011-08-30 20:07 ` [PATCH 1/2] alua: clarify messages when blk_execute_rq fails Rob Evers
2011-08-30 21:37 ` James Bottomley
2011-08-31 1:12 ` Rob Evers [this message]
2011-09-02 20:21 ` Rob Evers
2011-10-06 22:07 ` Rob Evers
2011-10-07 6:12 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5D8A8F.6000104@redhat.com \
--to=revers@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.