From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f47.google.com ([209.85.214.47]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QyeqF-0007b8-50 for openembedded-devel@lists.openembedded.org; Wed, 31 Aug 2011 09:04:07 +0200 Received: by bkbzu17 with SMTP id zu17so487799bkb.6 for ; Tue, 30 Aug 2011 23:59:13 -0700 (PDT) Received: by 10.204.133.11 with SMTP id d11mr28371bkt.291.1314773952940; Tue, 30 Aug 2011 23:59:12 -0700 (PDT) Received: from fensuse.internal.dresearch-fe.de (pd95cb174.dip0.t-ipconnect.de [217.92.177.116]) by mx.google.com with ESMTPS id a15sm234755bkg.17.2011.08.30.23.59.10 (version=SSLv3 cipher=OTHER); Tue, 30 Aug 2011 23:59:11 -0700 (PDT) Message-ID: <4E5DDBBE.4050007@dresearch-fe.de> Date: Wed, 31 Aug 2011 08:59:10 +0200 From: Steffen Sledz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <4E4E536D.7010103@dresearch-fe.de> <4E4E738C.70109@dresearch-fe.de> <4E5356B2.3060908@dresearch-fe.de> <4E53583A.3030405@gmx.net> <4E535B83.9080508@dresearch-fe.de> <1314199372.21496.12.camel@jjg-linux> <4E562AFF.7090004@dresearch-fe.de> <4E56579C.7080207@dresearch-fe.de> <4E5CC094.2020500@dresearch-fe.de> <1314707457.3796.19.camel@mattotaupa> In-Reply-To: <1314707457.3796.19.camel@mattotaupa> X-Enigmail-Version: 1.3.1 Cc: Paul Menzel Subject: Re: [2011.03-maintenance] do_compile failed for cacao_0.99.3.bb X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2011 07:04:07 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30.08.2011 14:30, Paul Menzel wrote: > Am Dienstag, den 30.08.2011, 12:51 +0200 schrieb Steffen Sledz: >> On 25.08.2011 16:09, Steffen Sledz wrote: >>> On 25.08.2011 12:59, Steffen Sledz wrote: >>>> On 24.08.2011 17:22, Jesse Gilles wrote: >>>>> On Tue, 2011-08-23 at 13:16 -0400, George C. Huntington, III wrote: >>>>>> I suspect that the problem is happening earlier, classpath isn't building. >>>>>> the javac wrapper eats the return code from a java compile. >>>>> >>>>> If George is right, then the following patch to the javac wrapper script >>>>> may fix the issue. It fixes building classpath as well as returns the >>>>> error code if all javac attempts fail. >>>>> >>>>> http://patches.openembedded.org/patch/9521/ >>>> >>>> In our case this patch helps. >>>> >>>> If nobody has objections i will commit this patch to oe-dev master and request a pull to 2011.03-maintenance. >>> >>> It would be still better if we can get some Acks from a java maintainer. >> >> No NACKs after another week. So i pushed the patch do oe-dev master. > > Next time it would be better to resend the patch with a appropriate > subject line. > > Unfortunately the commit message [1] does not conform to our commit > policy [2]. > > Please make sure to check those things next time. I feel uncomfortable > to ask new contributors to comply every time but when they look at the > commit history they see that the policies are often not cared about. Mea culpa. I should have asked the contributor to resend the patch with a policy conforming comment. Sorry. Do we still have a chance to change the comment if the patch was already pushed? Steffen > [1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=16a8a1e9175035b55d91a141d5302c38d63c16f1 > [2] http://openembedded.org/index.php/Category:Policy -- DResearch Fahrzeugelektronik GmbH Otto-Schmirgal-Str. 3, 10319 Berlin, Germany Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de Fax: +49 30 515932-299 Geschäftsführer: Dr. Michael Weber, Werner Mögle; Amtsgericht Berlin Charlottenburg; HRB 130120 B; Ust.-IDNr. DE273952058