From: Gerd Hoffmann <kraxel@redhat.com>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: alevy@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org
Subject: Re: [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949
Date: Wed, 31 Aug 2011 14:12:32 +0200 [thread overview]
Message-ID: <4E5E2530.7030309@redhat.com> (raw)
In-Reply-To: <4E5E1869.2060503@redhat.com>
Hi,
>> You can call qxl_set_irq unconditionally,
>> it checks for int_pending anyway.
> Hi,
> qxl_set_irq doesn't test int_pending, but it will call qemu_set_irq with
> level=0 if !int_pending.
Yes. Also checks int_mask. That is fine, isn't it?
BTW: qxl_update_irq would be a better name, this is what it actually
does: update irq line state from device state.
cheers,
Gerd
prev parent reply other threads:[~2011-08-31 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 8:20 [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949 Yonit Halperin
2011-08-31 10:23 ` Gerd Hoffmann
2011-08-31 11:18 ` Yonit Halperin
2011-08-31 12:12 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5E2530.7030309@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@freedesktop.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.