From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, s.koylux@gmail.com
Subject: Re: [PATCH] kconfig: protect locale-unsafe calls
Date: Wed, 31 Aug 2011 14:19:04 +0200 [thread overview]
Message-ID: <4E5E26B8.5030606@suse.cz> (raw)
In-Reply-To: <1313471973-13966-1-git-send-email-lacombar@gmail.com>
On 16.8.2011 07:19, Arnaud Lacombe wrote:
> There is a few calls in kconfig where we end-up using tolower(3) or toupper(3)
> in an unsafe manner. As highlighted by Serdar, it would seem that Turkish's
> locale do not have representable lowercase for the Engligh capital-dotless-i.
>
> Introduces locale-safe portion in the backend where we reset the local to the
> default "C".
>
> Reported-by: Serdar KÖYLÜ <s.koylux@gmail.com>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> scripts/kconfig/confdata.c | 10 ++++++++++
I think that just changing kconfig will make things even worse, because
fixdep does the same operation (CONFIG_FOO -> include/config/foo.h) and
would get out of sync with kconfig now. I guess the direct cause for
Serdar's build failure was this staging driver:
drivers/staging/cxt1e1/sbecom_inline_linux.h:
53 #if defined(CONFIG_MODVERSIONS) && defined(MODULE) && !
defined(MODVERSIONS)
54 #define MODVERSIONS
55 #endif
56
57 #ifdef MODULE
58 #ifdef MODVERSIONS
59 #include <config/modversions.h>
^^^^^^^^^^^^^^^^^^^^
60 #endif
61 #include <linux/module.h>
62 #endif
63 #endif
I'll send a patch cleaning this up once I verify that it really is the
cause.
As for the tollower/toupper issue, I would propose a much simpler way:
Let's not try to be cute and simply use include/config/FOO_BAR.h for
each CONFIG_FOO_BAR. x86_64 allmodconfig results in some 5k symbols
enabled, I'm sure any filesystem will handle a directory with 5k files
in it.
Michal
next prev parent reply other threads:[~2011-08-31 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 5:19 [PATCH] kconfig: protect locale-unsafe calls Arnaud Lacombe
2011-08-16 5:21 ` Arnaud Lacombe
2011-08-31 12:19 ` Michal Marek [this message]
2011-08-31 13:31 ` [PATCH] staging/cxt1e1: Header cleanup Michal Marek
2011-08-31 13:35 ` [PATCH] kconfig: protect locale-unsafe calls Arnaud Lacombe
2011-09-01 14:23 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5E26B8.5030606@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=s.koylux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.