Re: Add clkdev support to HSMMC

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

Hi Thomas,

On 08/31/2011 12:13 PM, Thomas Abraham wrote:
> 
> [...]
> 
> 
>>> 3) In the proposed implementation where we create connection ids only for the
>>> bus clocks we are creating an extra node for the same in the clkdev table,
>>
>>> where as the clock is getting registered only once with the kernel.
>>
>> I don't agree with this last statement, the same struct clk is added to
>> the list of clocks known by the system twice, in s3c24xx_register_clocks()
>> and clkdev_add_table(). This is only what I have been pointing out.
>> Please correct me, if I missed anything.
> 
> s3c24xx_register_clock and clkdev_add_table add one instance of
> "struct clk_lookup" each (with different connections ids) but both of
> these "struct clk_lookup" instances point to the same "struct clk"
> instance.

Yes, that's what happens in Banajit's code.

> 
> So, is two instances of "struct clk_lookup" pointing to the same
> "struct clk" instance the concern in this case?

No, I don't see this as a problem. Just wanted to get things clarified.

And to suggest that we could avoid having re-created struct clk and struct
clk_clksrc arrays for s3c24xx_register_clocks() and s3c_register_clksrc()
functions. However I don't consider this a significant issue.

--
Regards,
Sylwester
-- 
Sylwester Nawrocki
Samsung Poland R&D Center