All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] kvm_unit_tests: vm.c - Retrieve RAM size from fwcfg
Date: Thu, 01 Sep 2011 11:05:30 +0300	[thread overview]
Message-ID: <4E5F3CCA.4040700@redhat.com> (raw)
In-Reply-To: <1314825072-27967-1-git-send-email-lmr@redhat.com>

On 09/01/2011 12:11 AM, Lucas Meneghel Rodrigues wrote:
> Rather than letting the test dev do it.

> +
> +unsigned fwcfg_get_ram_size(void)
> +{
> +    return fwcfg_get_u64(FW_CFG_RAM_SIZE);
> +}

Should return a 64-bit type here.


-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm_unit_tests: vm.c - Retrieve RAM size from fwcfg
Date: Thu, 01 Sep 2011 11:05:30 +0300	[thread overview]
Message-ID: <4E5F3CCA.4040700@redhat.com> (raw)
In-Reply-To: <1314825072-27967-1-git-send-email-lmr@redhat.com>

On 09/01/2011 12:11 AM, Lucas Meneghel Rodrigues wrote:
> Rather than letting the test dev do it.

> +
> +unsigned fwcfg_get_ram_size(void)
> +{
> +    return fwcfg_get_u64(FW_CFG_RAM_SIZE);
> +}

Should return a 64-bit type here.


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-09-01  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 21:11 [PATCH] kvm_unit_tests: vm.c - Retrieve RAM size from fwcfg Lucas Meneghel Rodrigues
2011-08-31 21:11 ` [Qemu-devel] " Lucas Meneghel Rodrigues
2011-09-01  8:05 ` Avi Kivity [this message]
2011-09-01  8:05   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5F3CCA.4040700@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.