From: Felix Fietkau <nbd@openwrt.org>
To: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rmanohar@qca.qualcomm.com, shafi.wireless@gmail.com,
vthiagar@qca.qualcomm.com
Subject: Re: [PATCH v11 3/4] ath9k: merge reset related functions
Date: Thu, 01 Sep 2011 19:11:01 +0200 [thread overview]
Message-ID: <4E5FBCA5.7020201@openwrt.org> (raw)
In-Reply-To: <CAB=NE6WXTs_wnoW0cdSNp=BrL=QnR=D2KNOcT6n4MOYOtE8sJQ@mail.gmail.com>
On 2011-09-01 7:01 PM, Luis R. Rodriguez wrote:
> On Wed, Aug 31, 2011 at 4:32 PM, Felix Fietkau<nbd@openwrt.org> wrote:
>> reduces unnecessary code duplication. Also takes the sc_pcu_lock within
>> ath_reset instead of callsites, which makes it possible to always cancel
>> all queued work items before the reset, possibly fixing a few race
>> conditions (work items vs reset) along with it.
>>
>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
>
> This was a bit hard to review, if helpers are being added can they be
> added without changing code around, and in some other patch make the
> changes you describe?
I don't think it can be easily split up, because the change to use the
helper functions depends other things like the change to queue the reset
work instead of calling ath_reset directly.
- Felix
next prev parent reply other threads:[~2011-09-01 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 23:32 [PATCH v11 1/4] ath9k: eliminate common->{rx,tx}_chainmask Felix Fietkau
2011-08-31 23:32 ` [PATCH v11 2/4] ath9k: always call ath_reset from workqueue context Felix Fietkau
2011-08-31 23:32 ` [PATCH v11 3/4] ath9k: merge reset related functions Felix Fietkau
2011-08-31 23:32 ` [PATCH v11 4/4] ath9k: implement .get_antenna and .set_antenna Felix Fietkau
2011-09-01 17:01 ` [PATCH v11 3/4] ath9k: merge reset related functions Luis R. Rodriguez
2011-09-01 17:11 ` Felix Fietkau [this message]
2011-09-01 17:32 ` Luis R. Rodriguez
2011-09-01 16:54 ` [PATCH v11 2/4] ath9k: always call ath_reset from workqueue context Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5FBCA5.7020201@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=rmanohar@qca.qualcomm.com \
--cc=shafi.wireless@gmail.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.