From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] MX25: tx25: Avoid the usage of extern in C file
Date: Fri, 02 Sep 2011 09:22:33 +0200 [thread overview]
Message-ID: <4E608439.3010709@denx.de> (raw)
In-Reply-To: <4E60825D.9060201@denx.de>
On 09/02/2011 09:14 AM, Stefano Babic wrote:
> On 08/30/2011 02:20 PM, Fabio Estevam wrote:
>> Avoid the usage of extern in C file as pointed out by checkpatch.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>
Hi Fabio,
> Applied to u-boot-imx, as a fix, thanks.
Sorry, it is not. Your patch introduces warnings for the tx25 board:
Configuring for tx25 board...
tx25.c: In function 'board_init':
tx25.c:145: warning: implicit declaration of function 'mx25_uart1_init_pins'
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2011-09-02 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 12:20 [U-Boot] [PATCH v2 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-08-30 12:20 ` [U-Boot] [PATCH v2 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-09-02 7:14 ` [U-Boot] [PATCH v2 1/2] MX25: tx25: Avoid the usage of extern in C file Stefano Babic
2011-09-02 7:22 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E608439.3010709@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.