Re: [Qemu-devel] pseries machine updates

[Alexander Graf <agraf@suse.de>]

On 09/01/2011 03:45 AM, David Gibson wrote:
> On Wed, Aug 31, 2011 at 11:17:13AM +0200, Alexander Graf wrote:
>> On 11.08.2011, at 02:39, David Gibson wrote:
>>
>>> On Wed, Aug 10, 2011 at 05:16:35PM +0200, Alexander Graf wrote:
>>>> On 08/04/2011 09:02 AM, David Gibson wrote:
>>>>> Hi Alex,
>>>>>
>>>>> Here's another batch of assorted updates for the pseries machine.
>>>> Looks pretty nice. Please update patch 2/6 with the bug you found
>>>> and the whitespace problems. I'll put the others into my tree
>>>> already.
>>> Here's the updated 2/6
>>>
>>>  From e5b9ba608d4814a46f256337bbf60b94fdc2c5d9 Mon Sep 17 00:00:00 2001
>>> From: Ben Herrenschmidt<benh@kernel.crashing.org>
>>> Date: Thu, 4 Aug 2011 16:56:41 +1000
>>> Subject: [PATCH] Implement POWER7's CFAR in TCG
>>>
>>> This patch implements support for the CFAR SPR on POWER7 (Come From
>>> Address Register), which snapshots the PC value at the time of a branch or
>>> an rfid.  The latest powerpc-next kernel also catches it and can show it in
>>> xmon or in the signal frames.
>>>
>>> This works well enough to let recent kernels boot (which otherwise oops
>>> on the CFAR access).  It hasn't been tested enough to be confident that the
>>> CFAR values are actually accurate, but one thing at a time.
>>>
>>> Signed-off-by: Ben Herrenschmidt<benh@kernel.crashing.org>
>>> Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
>> agraf@lychee:/home/agraf/release/qemu>  git pw am 109480
>> ERROR: code indent should never use tabs
>> #107: FILE: target-ppc/translate.c:162:
>> +^I^I^I^I  offsetof(CPUState, cfar), "cfar");$
>>
>> ERROR: code indent should never use tabs
>> #174: FILE: target-ppc/translate.c:9289:
>> +^Icpu_fprintf(f, " CFAR " TARGET_FMT_lx"\n", env->cfar);$
> Blah.  Fixed now, I'll try to get BenH to use the emacs magic to stop
> it putting tabs in.
>
>> WARNING: space prohibited between function name and open parenthesis '('
>> #199: FILE: target-ppc/translate_init.c:134:
>> +static void spr_read_cfar (void *opaque, int gprn, int sprn)
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> #204: FILE: target-ppc/translate_init.c:139:
>> +static void spr_write_cfar (void *opaque, int sprn, int gprn)
> Well, these are deliberate, on the grounds that matching the
> surrounding functions seemed more important than matching the global
> style guidelines.
>
> Revised patch below
>
>  From b35b94ea867550faf99fc553b661739551c9bb8b Mon Sep 17 00:00:00 2001
> From: Ben Herrenschmidt<benh@kernel.crashing.org>
> Date: Thu, 4 Aug 2011 16:56:41 +1000
> Subject: [PATCH] Implement POWER7's CFAR in TCG
>
> This patch implements support for the CFAR SPR on POWER7 (Come From
> Address Register), which snapshots the PC value at the time of a branch or
> an rfid.  The latest powerpc-next kernel also catches it and can show it in
> xmon or in the signal frames.
>
> This works well enough to let recent kernels boot (which otherwise oops
> on the CFAR access).  It hasn't been tested enough to be confident that the
> CFAR values are actually accurate, but one thing at a time.
>
> Signed-off-by: Ben Herrenschmidt<benh@kernel.crashing.org>
> Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> ---
>   target-ppc/cpu.h            |    8 ++++++++
>   target-ppc/translate.c      |   28 ++++++++++++++++++++++++++++
>   target-ppc/translate_init.c |   23 ++++++++++++++++++++++-
>   3 files changed, 58 insertions(+), 1 deletions(-)

Thanks, applied. Please resend patches as full patches though. Patchwork 
doesn't deal too well with updated inline patches.


Alex