From: Earl Chew <echew@ixiacom.com>
To: Oleg Nesterov <oleg@redhat.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"andi@firstfloor.org" <andi@firstfloor.org>
Subject: Re: [PATCH 1/1 v2]: coredump: use current->group_leader->comm instead of current->comm
Date: Fri, 2 Sep 2011 16:05:06 -0700 [thread overview]
Message-ID: <4E616122.3030901@ixiacom.com> (raw)
In-Reply-To: <20110902174806.GA9238@redhat.com>
Oleg, Alan,
> Who knows? But once again, we use ->comm in the very unlikely case.
>
> And let me repeat just in case. I do not argue, I agree either way.
I understand.
Before I give thought to reworking the change, perhaps some other
considerations.
The other interesting thing is that Alan brought up the relevant point
about stuff breaking.
Alan Cox wrote:
> Earl wrote:
>> Change corepattern %e and %E to use current->group_leader->comm instead of current->comm.
>
> Which might break stuff.
What are your thoughts regarding the introduction of cn_escape() in this patch ?
https://lkml.org/lkml/2011/6/7/292
While this change also has merit, it is also breaking change. There might
be code relying on %e containing embedded slashes, either directly in
core pattern:
%e.core
or via the pipe:
| /opt/corehandler '%e'
Isn't the interface change introduced by cn_escape() also a concern ?
Earl
prev parent reply other threads:[~2011-09-02 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:01 [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm Earl Chew
2011-09-01 18:55 ` Alan Cox
2011-09-01 19:12 ` [PATCH 1/1 v2]: " Earl Chew
2011-09-02 16:30 ` Oleg Nesterov
2011-09-02 17:09 ` Earl Chew
2011-09-02 17:48 ` Oleg Nesterov
2011-09-02 23:05 ` Earl Chew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E616122.3030901@ixiacom.com \
--to=echew@ixiacom.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.