Re: [PATCH] [media] dvb-core, tda18271c2dd: define get_if_frequency() callback

[Antti Palosaari <crope@iki.fi>]

On 09/03/2011 06:24 PM, Antti Palosaari wrote:
> On 09/03/2011 06:12 PM, Mauro Carvalho Chehab wrote:
>> The DRX-K frontend needs to know the IF frequency in order to work,
>> just like all other frontends. However, as it is a multi-standard
>> FE, the IF may change if the standard is changed. So, the usual
>> procedure of passing it via a config struct doesn't work.
>>
>> One might code it as two separate IF frequencies, one by each type
>> of FE, but, as, on tda18271, the IF changes if the bandwidth for
>> DVB-C changes, this also won't work.
>>
>> So, the better is to just add a new callback for it and require
>> it for the tuners that can be used with MFE frontends like drx-k.
>>
>> It makes sense to add support for it on all existing tuners, and
>> remove the IF parameter from the demods, cleaning up the code.
>
> Is it clear that only used tuner IC defines used IF?
>
> I have seen some cases where used IF is different depending on other
> used hardware, even same tuner IC used. Very good example is to see all
> configuration structs of old tda18271 driver. Those are mainly used for
> setting different IF than tuner default...

Hmm, I think that will actually only reduce defining same IFs to demod 
which are already set to tuner allowing to remove "redundant" demod 
definitions. OK, now it looks fine for me.

Acked-by: Antti Palosaari <crope@iki.fi>


Antti
-- 
http://palosaari.fi/