From: Clemens Ladisch <clemens@ladisch.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: sarah.a.sharp@linux.intel.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb: refine delay information with USB frame counter
Date: Mon, 05 Sep 2011 09:53:26 +0200 [thread overview]
Message-ID: <4E647FF6.2000205@ladisch.de> (raw)
In-Reply-To: <1314642732-8909-1-git-send-email-pierre-louis.bossart@linux.intel.com>
Pierre-Louis Bossart wrote:
> ... This should improve audio/video sync
It does indeed; mplayer's A-V difference gets lowered from up to
nrpacks ms down to at most 1 ms.
> + est_delay = subs->last_delay-(frame_diff*rate/1000L);
Why a long dividend?
The spacing around operators is inconsistent; please use checkpatch.
> + snd_printk(KERN_DEBUG "ALSA usb.c: Delay %d actual delay %d\n",
> + est_delay, subs->last_delay);
snd_printk already can print the "ALSA" and file name prefixes.
(And it uses the correct file name. ;-)
Regards,
Clemens
next prev parent reply other threads:[~2011-09-05 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 18:32 [PATCH] ALSA: usb: refine delay information with USB frame counter Pierre-Louis Bossart
2011-08-30 7:59 ` Clemens Ladisch
2011-08-30 15:34 ` Pierre-Louis Bossart
2011-09-05 7:53 ` Clemens Ladisch [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-24 21:26 Pierre-Louis Bossart
2011-08-25 7:54 ` Clemens Ladisch
2011-08-25 14:00 ` Pierre-Louis Bossart
[not found] ` <002301cc632f$5bfe0a90$13fa1fb0$@bossart@linux.intel.com>
2011-08-25 14:07 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E647FF6.2000205@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.