All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PPC4xx: ALPR: constify FPGA code
Date: Mon, 05 Sep 2011 14:24:50 +0400	[thread overview]
Message-ID: <4E64A372.8030506@mvista.com> (raw)
In-Reply-To: <1315215809-18490-1-git-send-email-wd@denx.de>

Hello.

On 05-09-2011 13:43, Wolfgang Denk wrote:

> The ALPR custom FPGA code was missed by commit e6a857d "fpga:
> constify to fix build warning" resulting in such warnings:

> fpga.c:226: warning: initialization from incompatible pointer type

> Signed-off-by: Wolfgang Denk<wd@denx.de>
> Cc: Stefan Roese<sr@denx.de>
> ---
>   board/prodrive/alpr/fpga.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/board/prodrive/alpr/fpga.c b/board/prodrive/alpr/fpga.c
> index 93f2449..3666a9a 100644
> --- a/board/prodrive/alpr/fpga.c
> +++ b/board/prodrive/alpr/fpga.c
> @@ -168,7 +168,7 @@ int fpga_done_fn (int cookie)
>   /* writes the complete buffer to the FPGA
>      writing the complete buffer in one function is much faster,
>      then calling it for every bit */
> -int fpga_write_fn (void *buf, size_t len, int flush, int cookie)
> +int fpga_write_fn (const void *buf, size_t len, int flush, int cookie)

    I guess this causes checkpatch.pl to complain due to space before (...

WBR, Sergei

  parent reply	other threads:[~2011-09-05 10:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05  9:43 [U-Boot] [PATCH] PPC4xx: ALPR: constify FPGA code Wolfgang Denk
2011-09-05  9:50 ` Stefan Roese
2011-09-05 10:25   ` Wolfgang Denk
2011-09-05 10:24 ` Sergei Shtylyov [this message]
2011-09-05 10:31   ` Wolfgang Denk
2011-09-05 10:54   ` [U-Boot] [PATCH] [COSMETIC] board/prodrive/alpr/fpga.c: Coding style cleanup Wolfgang Denk
2011-09-05 11:34     ` [U-Boot] [PATCH v2] " Wolfgang Denk
2011-09-05 12:00       ` Stefan Roese
2011-09-05 13:47       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E64A372.8030506@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.