All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: beagle: Fix build warning
Date: Mon, 05 Sep 2011 13:35:50 +0200	[thread overview]
Message-ID: <4E64B416.40708@aribaud.net> (raw)
In-Reply-To: <1315218353-18173-1-git-send-email-premi@ti.com>

Hi Sanjeev,

Le 05/09/2011 12:25, Sanjeev Premi a ?crit :
> This patch fixes the warning dure to recent changes to the board
> configuration:
> cmd_i2c.o cmd_i2c.c -c
> cmd_i2c.c:109:1: warning: missing braces around initializer
> cmd_i2c.c:109:1: warning: (near initialization for 'i2c_no_probes[0]')
>
> Signed-off-by: Sanjeev Premi<premi@ti.com>
> Cc: Jason Kridner<jkridner@beagleboard.org>
> ---
>
>   Patch was compile tested against the latest u-boot-arm.git at:
>   58c583b : net: Check network device driver name
>
>   include/configs/omap3_beagle.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index 18c6deb..a891246 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -118,7 +118,7 @@
>   #define CONFIG_I2C_MULTI_BUS		1
>
>   /* Probe all devices */
> -#define CONFIG_SYS_I2C_NOPROBES		{0x0, 0x0}
> +#define CONFIG_SYS_I2C_NOPROBES		{{0x0, 0x0}}
>
>   /* USB */
>   #define CONFIG_MUSB_UDC			1

Won't all board configs which use CONFIG_SYS_I2C_NOPROBES suffer from 
the same bug? I would hate to see an endless trickle of individual board 
config patches, and would much prefer a single patch to fix all boards 
in one go if you are willing to do it -- yes, it would touch boards that 
you cannot even test, but I'd say the risk is next to zero.

Wolfgang, Heiko, your opinion?

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-09-05 11:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 10:25 [U-Boot] [PATCH] omap3: beagle: Fix build warning Sanjeev Premi
2011-09-05 11:35 ` Albert ARIBAUD [this message]
2011-09-05 11:47   ` Premi, Sanjeev
2011-09-05 13:30     ` Heiko Schocher
2011-09-05 14:42       ` Premi, Sanjeev
2011-09-06 22:00 ` Jason Kridner
2011-09-07  6:11 ` Albert ARIBAUD
2011-09-07  7:41   ` Stefano Babic
2011-09-07  8:47     ` Premi, Sanjeev
2011-09-07 13:04       ` Albert ARIBAUD
2011-09-07 14:12         ` Paulraj, Sandeep
2011-09-07 21:40         ` Joel A Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E64B416.40708@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.