From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0YJF-00039u-Jd for qemu-devel@nongnu.org; Mon, 05 Sep 2011 08:29:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0YJA-0007ef-IF for qemu-devel@nongnu.org; Mon, 05 Sep 2011 08:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0YJA-0007eJ-A5 for qemu-devel@nongnu.org; Mon, 05 Sep 2011 08:29:48 -0400 Message-ID: <4E64C16B.5040501@redhat.com> Date: Mon, 05 Sep 2011 14:32:43 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1314116912-28685-1-git-send-email-sage@newdream.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] rbd: fix leak in qemu_rbd_open failure paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sage Weil Cc: Stefan Hajnoczi , qemu-devel@nongnu.org Am 04.09.2011 18:19, schrieb Sage Weil: > Fix leak of s->snap in failure path. Simplify error paths for the whole > function. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Sage Weil This depends on "[PATCH v2] rbd: allow client id to be specified in config string", which doesn't seem to apply any more and has coding style issues. Please fix and send a rebased series containing all four patches. Kevin