From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices
Date: Mon, 05 Sep 2011 15:03:43 +0200 [thread overview]
Message-ID: <4E64C8AF.7040506@redhat.com> (raw)
In-Reply-To: <20110901155620.GB11219@lst.de>
Am 01.09.2011 17:56, schrieb Christoph Hellwig:
> On Thu, Sep 01, 2011 at 03:27:35PM +0100, Daniel P. Berrange wrote:
>> One other question too, when creating a qcow2 image via 'qemu-img create'
>> you can specify a 'prealloc' option to require metadata to be allocated
>> at time of creation.
>>
>> Should we have the same control at time of resize too. If the app had
>> originally created the qcow2 image with preallocated metadata, then
>> I'd expect they want to pre-allocate metadata when extending it too,
>> or is there no additional metadata allocation required when extending
>> an image ?
>
> Sounds reasonable. Keving, is there a sane way to implement this?
Implementing the functionality itself shouldn't be a big problem. The
big question is what the right interface would look like.
We have driver specific preallocation options, so we would end up with
something like this: bdrv_truncate(bs, int64_t size, char*
prealloc_mode). Not exactly nice. And is preallocation the only thing or
would we need to pass a whole option list like for image creation?
Of course, if this is a real requirement and not only a random thought,
we can always introduce a specific flag for the current use case and add
the generic thing only later when we have thought a bit more about it.
Kevin
prev parent reply other threads:[~2011-09-05 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 13:27 [Qemu-devel] QEMU online guest disk resize wrt host block devices Daniel P. Berrange
2011-09-01 14:05 ` Christoph Hellwig
2011-09-01 14:30 ` Daniel P. Berrange
2011-09-01 15:55 ` Christoph Hellwig
2011-09-02 15:00 ` Daniel P. Berrange
2011-09-07 11:02 ` [Qemu-devel] [PATCH] block: allow resizing of images residing on host devices Christoph Hellwig
2011-09-09 9:37 ` Kevin Wolf
2011-09-01 14:27 ` [Qemu-devel] QEMU online guest disk resize wrt host block devices Daniel P. Berrange
2011-09-01 15:56 ` Christoph Hellwig
2011-09-05 13:03 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64C8AF.7040506@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.