From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c_no_probes: Fix initialization warnings
Date: Mon, 05 Sep 2011 15:42:46 +0200 [thread overview]
Message-ID: <4E64D1D6.7040909@denx.de> (raw)
In-Reply-To: <1315226172-20554-1-git-send-email-premi@ti.com>
Hello Sanjeev,
Sanjeev Premi wrote:
> This patch fixes the initialization warnings similar to
> the one below:
> cmd_i2c.o cmd_i2c.c -c
> cmd_i2c.c:109:1: warning: missing braces around initializer
> cmd_i2c.c:109:1: warning: (near initialization for 'i2c_no_probes[0]')
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>
> The problem was originally found when compiling omap3_beagle[1].
> All the changes were done with this bash script:
>
> [script_here]
> list=search.lst
> [ -f ${list} ] && \rm -rf ${list}
>
> grep CONFIG_SYS_I2C_NOPROBES ./include/configs/* | grep -v "{{" | cut -d":" -f1 > ${list}
>
> for f in `cat ${list}` ;
> do
> echo "Fixing $f..."
> sed -r -i 's/(CONFIG_SYS_I2C_NOPROBES\s*)\{{1}(.*)\}{1}/\1{{\2}}/g' "$f"
> done
> [/script_here]
>
> Compile tested for oma3_beagle only.
Compiling for example for the alpr board with your patch:
[hs at pollux u-boot]$ ./MAKEALL alpr
Configuring for alpr board...
cmd_i2c.c:115: warning: braces around scalar initializer
cmd_i2c.c:115: warning: (near initialization for 'i2c_no_probes[0]')
fpga.c:226: warning: initialization from incompatible pointer type
text data bss dec hex filename
231746 18612 68328 318686 4dcde ./u-boot
--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with warnings or errors: 1 ( alpr )
----------------------------------------------------------
[hs at pollux u-boot]$
-> so Sorry, NACK for this patch.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-09-05 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 12:36 [U-Boot] [PATCH] i2c_no_probes: Fix initialization warnings Sanjeev Premi
2011-09-05 13:42 ` Heiko Schocher [this message]
2011-09-05 15:01 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64D1D6.7040909@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.