All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Rankin <rankincj@yahoo.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
Date: Mon, 05 Sep 2011 15:26:32 +0100	[thread overview]
Message-ID: <4E64DC18.1060308@yahoo.com> (raw)
In-Reply-To: <4E64D566.4070105@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On 05/09/11 14:57, Mauro Carvalho Chehab wrote:
> Could you please provide me a patch for it? I'll merge with your original one
> when submitting it upstream.

Here you go. Did you also pick up the other merge fix and the (separate) memory 
leak fix, please?

Cheers,
Chris

Signed-off-by: Chris Rankin <rankincj@yahoo.com>


[-- Attachment #2: EM28xx-devlist-merge-fix.diff --]
[-- Type: text/x-patch, Size: 354 bytes --]

--- linux/drivers/media/video/em28xx/em28xx-cards.c.orig	2011-09-05 15:21:38.000000000 +0100
+++ linux/drivers/media/video/em28xx/em28xx-cards.c	2011-09-05 15:21:55.000000000 +0100
@@ -2885,7 +2885,6 @@
 		retval = em28xx_audio_setup(dev);
 		if (retval)
 			return -ENODEV;
-		em28xx_add_into_devlist(dev);
 		em28xx_init_extension(dev);
 
 		return 0;

  reply	other threads:[~2011-09-05 14:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-04 23:46 ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! Antti Palosaari
2011-09-05  0:15 ` Chris Rankin
2011-09-05  0:24   ` Antti Palosaari
2011-09-05  0:34     ` Chris Rankin
2011-09-05 13:57       ` Mauro Carvalho Chehab
2011-09-05 14:26         ` Chris Rankin [this message]
2011-09-05  0:24 ` Chris Rankin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E64DC18.1060308@yahoo.com \
    --to=rankincj@yahoo.com \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.