From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4E65C326.3010506@broadcom.com> Date: Mon, 5 Sep 2011 23:52:22 -0700 From: "Bhanu Prakash Gollapudi" MIME-Version: 1.0 References: <1314905304-16485-1-git-send-email-jpirko@redhat.com> <20110902122630.GC1991@minipsycho> <1314989161.3419.5.camel@bwh-desktop> <20110903133428.GA2821@minipsycho> <1315057614.3092.160.camel@deadeye> <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zou, Yi" Cc: "amit.salecha@qlogic.com" , "bridge@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , "devel@open-fcoe.org" , "linux-scsi@vger.kernel.org" , "decot@google.com" , "therbert@google.com" , "eric.dumazet@gmail.com" , "fubar@us.ibm.com" , "JBottomley@parallels.com" , "xiaosuo@gmail.com" , "paulmck@linux.vnet.ibm.com" , "Duyck, Alexander H" , "mirq-linux@rere.qmqm.pl" , Ben Hutchings , "greearb@candelatech.com" , "Love, Robert W" , "laijs@cn.fujitsu.com" , Jiri Pirko , "netdev@vger.kernel.org" , "ralf@linux-mips.org" , "davem@davemloft.net" , "loke.chetan@gmail.com" On 9/5/2011 8:25 PM, Zou, Yi wrote: >> >> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote: >>> This patch does several things: >>> - introduces __ethtool_get_settings which is called from ethtool code >> and >>> from drivers as well. Put ASSERT_RTNL there. >>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings() >>> - changes calling in drivers so rtnl locking is respected. In >>> iboe_get_rate was previously ->get_settings() called unlocked. This >>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same >>> problem. Also fixed by calling __dev_get_by_index() instead of >>> dev_get_by_index() and holding rtnl_lock for both calls. >>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() >>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they >>> are from other places. >>> - use __ethtool_get_settings() in bonding code >>> >>> Signed-off-by: Jiri Pirko >> Reviewed-by: Ben Hutchings [except FCoE bits] >> >> Ben. > FCoE bits look ok to me. Thanks, > > Reviewed-by: Yi Zou bnx2fc changes looks OK to me. Reviewed-by: Bhanu Prakash Gollapudi > >> >> -- >> Ben Hutchings, Staff Engineer, Solarflare >> Not speaking for my employer; that's the marketing department's job. >> They asked us to note that Solarflare product names are trademarked. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 06 Sep 2011 08:52:49 +0200 (CEST) Received: from mms3.broadcom.com ([216.31.210.19]:1450 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491067Ab1IFGwl (ORCPT ); Tue, 6 Sep 2011 08:52:41 +0200 Received: from [10.9.200.131] by MMS3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Mon, 05 Sep 2011 23:58:00 -0700 X-Server-Uuid: B55A25B1-5D7D-41F8-BC53-C57E7AD3C201 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Mon, 5 Sep 2011 23:52:22 -0700 Received: from [10.240.250.183] (unknown [10.240.250.183]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 4904874D03; Mon, 5 Sep 2011 23:52:21 -0700 (PDT) Message-ID: <4E65C326.3010506@broadcom.com> Date: Mon, 5 Sep 2011 23:52:22 -0700 From: "Bhanu Prakash Gollapudi" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.20) Gecko/20110804 Thunderbird/3.1.12 MIME-Version: 1.0 To: "Zou, Yi" cc: "Ben Hutchings" , "Jiri Pirko" , "netdev@vger.kernel.org" , "ralf@linux-mips.org" , "fubar@us.ibm.com" , "andy@greyhouse.net" , "kaber@trash.net" , "JBottomley@parallels.com" , "Love, Robert W" , "davem@davemloft.net" , "shemminger@linux-foundation.org" , "decot@google.com" , "mirq-linux@rere.qmqm.pl" , "Duyck, Alexander H" , "amit.salecha@qlogic.com" , "eric.dumazet@gmail.com" , "therbert@google.com" , "paulmck@linux.vnet.ibm.com" , "laijs@cn.fujitsu.com" , "xiaosuo@gmail.com" , "greearb@candelatech.com" , "loke.chetan@gmail.com" , "linux-mips@linux-mips.org" , "linux-scsi@vger.kernel.org" , "devel@open-fcoe.org" , "bridge@lists.linux-foundation.org" Subject: Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling References: <1314905304-16485-1-git-send-email-jpirko@redhat.com> <20110902122630.GC1991@minipsycho> <1314989161.3419.5.camel@bwh-desktop> <20110903133428.GA2821@minipsycho> <1315057614.3092.160.camel@deadeye> <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> X-WSS-ID: 627B1BF23KO14224740-01-01 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 31045 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: bprakash@broadcom.com Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 2898 On 9/5/2011 8:25 PM, Zou, Yi wrote: >> >> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote: >>> This patch does several things: >>> - introduces __ethtool_get_settings which is called from ethtool code >> and >>> from drivers as well. Put ASSERT_RTNL there. >>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings() >>> - changes calling in drivers so rtnl locking is respected. In >>> iboe_get_rate was previously ->get_settings() called unlocked. This >>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same >>> problem. Also fixed by calling __dev_get_by_index() instead of >>> dev_get_by_index() and holding rtnl_lock for both calls. >>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() >>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they >>> are from other places. >>> - use __ethtool_get_settings() in bonding code >>> >>> Signed-off-by: Jiri Pirko >> Reviewed-by: Ben Hutchings [except FCoE bits] >> >> Ben. > FCoE bits look ok to me. Thanks, > > Reviewed-by: Yi Zou bnx2fc changes looks OK to me. Reviewed-by: Bhanu Prakash Gollapudi > >> >> -- >> Ben Hutchings, Staff Engineer, Solarflare >> Not speaking for my employer; that's the marketing department's job. >> They asked us to note that Solarflare product names are trademarked. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bhanu Prakash Gollapudi" Subject: Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling Date: Mon, 5 Sep 2011 23:52:22 -0700 Message-ID: <4E65C326.3010506@broadcom.com> References: <1314905304-16485-1-git-send-email-jpirko@redhat.com> <20110902122630.GC1991@minipsycho> <1314989161.3419.5.camel@bwh-desktop> <20110903133428.GA2821@minipsycho> <1315057614.3092.160.camel@deadeye> <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C-osO9UTpF0UQd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org Errors-To: devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org To: "Zou, Yi" Cc: "amit.salecha-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org" , "bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , "JBottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org" , "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "decot-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org" , "therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org" , "xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org" , "Duyck, Alexander H" , "mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org" , Ben Hutchings , "greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org" List-Id: linux-scsi@vger.kernel.org On 9/5/2011 8:25 PM, Zou, Yi wrote: >> >> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote: >>> This patch does several things: >>> - introduces __ethtool_get_settings which is called from ethtool code >> and >>> from drivers as well. Put ASSERT_RTNL there. >>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings() >>> - changes calling in drivers so rtnl locking is respected. In >>> iboe_get_rate was previously ->get_settings() called unlocked. This >>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same >>> problem. Also fixed by calling __dev_get_by_index() instead of >>> dev_get_by_index() and holding rtnl_lock for both calls. >>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() >>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they >>> are from other places. >>> - use __ethtool_get_settings() in bonding code >>> >>> Signed-off-by: Jiri Pirko >> Reviewed-by: Ben Hutchings [except FCoE bits] >> >> Ben. > FCoE bits look ok to me. Thanks, > > Reviewed-by: Yi Zou bnx2fc changes looks OK to me. Reviewed-by: Bhanu Prakash Gollapudi > >> >> -- >> Ben Hutchings, Staff Engineer, Solarflare >> Not speaking for my employer; that's the marketing department's job. >> They asked us to note that Solarflare product names are trademarked. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bhanu Prakash Gollapudi" Subject: Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling Date: Mon, 5 Sep 2011 23:52:22 -0700 Message-ID: <4E65C326.3010506@broadcom.com> References: <1314905304-16485-1-git-send-email-jpirko@redhat.com> <20110902122630.GC1991@minipsycho> <1314989161.3419.5.camel@bwh-desktop> <20110903133428.GA2821@minipsycho> <1315057614.3092.160.camel@deadeye> <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: "amit.salecha-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org" , "bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , "JBottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org" , "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "decot-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org" , "therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org" , "xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org" , "Duyck, Alexander H" , "mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org" , Ben Hutchings , "greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org" Return-path: In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C-osO9UTpF0UQd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org Errors-To: devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org List-Id: netdev.vger.kernel.org On 9/5/2011 8:25 PM, Zou, Yi wrote: >> >> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote: >>> This patch does several things: >>> - introduces __ethtool_get_settings which is called from ethtool code >> and >>> from drivers as well. Put ASSERT_RTNL there. >>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings() >>> - changes calling in drivers so rtnl locking is respected. In >>> iboe_get_rate was previously ->get_settings() called unlocked. This >>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same >>> problem. Also fixed by calling __dev_get_by_index() instead of >>> dev_get_by_index() and holding rtnl_lock for both calls. >>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() >>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they >>> are from other places. >>> - use __ethtool_get_settings() in bonding code >>> >>> Signed-off-by: Jiri Pirko >> Reviewed-by: Ben Hutchings [except FCoE bits] >> >> Ben. > FCoE bits look ok to me. Thanks, > > Reviewed-by: Yi Zou bnx2fc changes looks OK to me. Reviewed-by: Bhanu Prakash Gollapudi > >> >> -- >> Ben Hutchings, Staff Engineer, Solarflare >> Not speaking for my employer; that's the marketing department's job. >> They asked us to note that Solarflare product names are trademarked. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html