From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path
Date: Tue, 06 Sep 2011 10:46:50 +0300 [thread overview]
Message-ID: <4E65CFEA.70604@redhat.com> (raw)
In-Reply-To: <CAAu8pHsACZ_jf=2yg7ZCTjz2fdA4q9y9bbbaQQNtRgq35gPw2A@mail.gmail.com>
On 09/05/2011 10:36 PM, Blue Swirl wrote:
> > I don't agree. That's not what qemu_irq represents.
> > It represents a wire, a mechanism to drive changes through logic paths
> > between state. It is intrinsically stateless.
> >
> > It may be the case that it is missused in some places, or that it isn't
> > always the best thing to use to represent what ever you need to represent,
> > so that you want to complement with other mechanisms.
> > But universally replacing it with a stateful alternative seems wrong to me.
>
> Maybe there could be a stateless version of Pin for optimization:
> Line? This would probably save one bool worth of memory and one memory
> store access for each IRQ event.
Let's actually measure the effect of the bool/store before we optimize
it away.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-09-06 7:46 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 14:16 [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path Jan Kiszka
2011-08-28 7:10 ` Blue Swirl
2011-08-28 9:08 ` Jan Kiszka
2011-08-29 19:25 ` Anthony Liguori
2011-08-29 21:06 ` Jan Kiszka
2011-08-29 21:13 ` Avi Kivity
2011-08-29 21:18 ` Jan Kiszka
2011-08-30 19:19 ` Blue Swirl
2011-08-30 19:28 ` Jan Kiszka
2011-08-30 19:43 ` Blue Swirl
2011-08-31 8:25 ` Peter Maydell
2011-08-31 10:53 ` Jan Kiszka
2011-08-31 17:41 ` Blue Swirl
2011-08-31 18:17 ` Jan Kiszka
2011-08-31 19:44 ` Blue Swirl
2011-09-04 10:33 ` Blue Swirl
2011-09-04 12:25 ` Gleb Natapov
2011-09-03 19:54 ` Anthony Liguori
2011-09-04 12:13 ` Jan Kiszka
2011-09-04 13:32 ` Anthony Liguori
2011-09-04 13:36 ` Jan Kiszka
2011-09-04 13:41 ` Anthony Liguori
2011-09-04 13:49 ` Jan Kiszka
2011-09-04 13:57 ` Anthony Liguori
2011-09-04 14:37 ` Anthony Liguori
2011-09-04 15:20 ` Blue Swirl
2011-09-04 15:31 ` Anthony Liguori
2011-09-04 15:44 ` Blue Swirl
2011-09-05 10:44 ` Edgar E. Iglesias
2011-09-04 14:12 ` Avi Kivity
2011-09-04 14:43 ` Anthony Liguori
2011-09-04 15:03 ` Avi Kivity
2011-09-04 15:19 ` Anthony Liguori
2011-09-04 15:34 ` Avi Kivity
2011-09-04 15:27 ` Blue Swirl
2011-09-04 12:17 ` Avi Kivity
2011-09-04 12:37 ` Jan Kiszka
2011-09-04 12:43 ` Avi Kivity
2011-09-04 13:38 ` Anthony Liguori
2011-09-04 13:42 ` Jan Kiszka
2011-09-04 13:55 ` Anthony Liguori
2011-09-04 13:35 ` Anthony Liguori
2011-08-31 8:28 ` Avi Kivity
2011-08-31 16:59 ` Blue Swirl
2011-08-31 18:04 ` Edgar E. Iglesias
2011-08-31 18:28 ` Jan Kiszka
2011-09-01 5:58 ` Avi Kivity
2011-09-03 20:07 ` Anthony Liguori
2011-09-03 21:10 ` Blue Swirl
2011-09-03 21:41 ` Anthony Liguori
2011-09-04 9:27 ` Blue Swirl
2011-09-03 19:53 ` Anthony Liguori
2011-09-03 21:01 ` Blue Swirl
2011-09-04 14:49 ` Anthony Liguori
2011-09-05 8:38 ` Edgar E. Iglesias
2011-09-05 8:51 ` Avi Kivity
2011-09-05 9:02 ` Peter Maydell
2011-09-05 9:14 ` Avi Kivity
2011-09-05 9:22 ` Edgar E. Iglesias
2011-09-05 9:28 ` Avi Kivity
2011-09-05 10:47 ` Edgar E. Iglesias
2011-09-05 19:36 ` Blue Swirl
2011-09-06 7:46 ` Avi Kivity [this message]
2011-09-01 9:08 ` [Qemu-devel] [PATCH v2] pc: Fix and clean " Jan Kiszka
2011-09-03 8:58 ` Blue Swirl
2011-09-03 11:17 ` Jan Kiszka
2011-09-03 11:37 ` Blue Swirl
2011-09-03 18:14 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E65CFEA.70604@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=jan.kiszka@web.de \
--cc=kraxel@redhat.com \
--cc=lmr@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.