All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caspar Zhang <czhang@redhat.com>
To: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [Patch 1/4] KSM test case fixes - ksm01
Date: Tue, 06 Sep 2011 17:24:04 +0800	[thread overview]
Message-ID: <4E65E6B4.2030209@redhat.com> (raw)
In-Reply-To: <4E64A194.2070805@linux.vnet.ibm.com>

On 09/05/2011 06:16 PM, Nageswara R Sastry wrote:
> +
> +	char *fname = "/sys/kernel/mm/ksm/";
> +
> +        if( access( fname, F_OK ) == -1 ) {
> +                tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
> +        }
>   }

Hi, thanks for the patch. However, there is already a macro defined in 
include/mem.h:

#define PATH_KSM                "/sys/kernel/mm/ksm/"

And I think the braces are not necessary here?

Thanks,
Caspar

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2011-09-06  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 10:16 [LTP] [Patch 1/4] KSM test case fixes - ksm01 Nageswara R Sastry
2011-09-06  9:24 ` Caspar Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E65E6B4.2030209@redhat.com \
    --to=czhang@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=rnsastry@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.