All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] glib mainloop breaks virtfs
Date: Tue, 06 Sep 2011 09:31:32 -0500	[thread overview]
Message-ID: <4E662EC4.4050705@codemonkey.ws> (raw)
In-Reply-To: <4E66027C.3090909@redhat.com>

On 09/06/2011 06:22 AM, Gerd Hoffmann wrote:
> Hi,
>
> virtfs stopped working for me in master, the guest (fedora 15) just
> hangs at boot when mounting the virtfs filesystems. Bisecting points to
> this commit:
>
> rincewind kraxel ~/projects/qemu ((69e5bb6...)|BISECTING)# git bisect good
> 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2 is the first bad commit
> commit 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2
> Author: Anthony Liguori <aliguori@us.ibm.com>
> Date: Mon Aug 22 08:12:53 2011 -0500
>
> main: switch qemu_set_fd_handler to g_io_add_watch

The v9fs code uses qemu_set_fd_handler to trigger coroutines.  I suspect 
this is not going to be a fun one to debug.

This changeset changes the ordering of when callbacks are fired so it 
may be triggering a latent bug in the coroutine usage in virtio-9p. 
Aneesh, can you take a look at it?

Regards,

Anthony Liguori

>
> cheers,
> Gerd
>

  reply	other threads:[~2011-09-06 14:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06 11:22 [Qemu-devel] glib mainloop breaks virtfs Gerd Hoffmann
2011-09-06 14:31 ` Anthony Liguori [this message]
2011-09-06 17:25   ` Aneesh Kumar K.V
2011-09-06 17:41     ` Aneesh Kumar K.V
2011-09-07 10:44 ` Aneesh Kumar K.V
2011-09-07 10:58   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E662EC4.4050705@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.