Re: [PATCHv5 3/3] Mobile broadband provider info plugin

[Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

Hello Denis,

On 08/30/2011 11:17 AM, Denis Kenzior wrote:
> The mobile-broadband-provider-info database would probably need to be
> extended with a fully-fledged SPN element to store this information.
> The current database is simply not setup this way.  To give you an
> example, in Australia most providers have the SPN structured something
> like this:
> '<ProviderName>  AU'
>
> So it is quite obvious why your logic above will fail ;)
>
> Other times the SPN name is a shortened / stylized name of the provider,
> e.g. Virgin Mobile ->  Virgin
>
> The current<name>  tag under the<provider>  tag is really for the user's
> benefit.

If the provider name isn't sufficient to serve as the SPN, shall we add optional 
SPN element on the same level?

<provider>
	<name>...</name>
	<spn>...</spn>
	<network-id mcc="123" mnc="12"/>
	<apn>...</apn>
</provider>

Can we drop this check until such SPN element can be upstreamed into the database?

>> For some tags, the parser calls body multiple times, first few times
>> supplying just '\n' and '\t's. Also, some tags have such a body that
>> DBG() has trouble to print without escaping. So, what's the method to
>> protect against the latter?
>
> This might be easier if you only run the parser on the bodies of the
> tags you really care about.  e.g. this problem might just go away when
> you use g_markup_parse_context_push/pop.

This place in the parser is already run only on bodies we care about, i.e. 
within mcc/mnc match. If the diagnostics on body is required, this problem won't 
go away if we use g_markup_parse_context_push/pop. So, do we keep the escaping 
or drop diagnostics of the element body? Or, propose a solution?

Regards,
Oleg
-- 
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki