From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 2/6] netfilter: ipset: Dumping error could lead to kernel BUG
Date: Wed, 07 Sep 2011 16:42:31 +0200 [thread overview]
Message-ID: <4E6782D7.3020101@trash.net> (raw)
In-Reply-To: <1315339147-9617-3-git-send-email-kadlec@blackhole.kfki.hu>
On 06.09.2011 21:59, Jozsef Kadlecsik wrote:
> If there was a dumping error in the middle, the set-specific variable was
> not zeroed out and thus the 'done' function of the dumping wrongly tried
> to release the already released reference of the set. The already released
> reference was caught by __ip_set_put and triggered a kernel BUG message.
> The issue was reported by Jean-Philippe Menil.
Applied, thanks.
next prev parent reply other threads:[~2011-09-07 16:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 19:59 [PATCH 0/6] ipset patches Jozsef Kadlecsik
2011-09-06 19:59 ` [PATCH 1/6] netfilter: ipset: Autoload set type modules safely Jozsef Kadlecsik
2011-09-07 14:41 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 2/6] netfilter: ipset: Dumping error could lead to kernel BUG Jozsef Kadlecsik
2011-09-07 14:42 ` Patrick McHardy [this message]
2011-09-06 19:59 ` [PATCH 3/6] netfilter: ipset: Remove unnecessary OOM logging messages Jozsef Kadlecsik
2011-09-07 14:42 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 4/6] netfilter: ipset: avoid use of kernel-only types Jozsef Kadlecsik
2011-09-07 14:44 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 5/6] netfilter: ipset: expose userspace-relevant parts in ip_set.h Jozsef Kadlecsik
2011-09-07 14:45 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 6/6] netfilter: ipset: use NFPROTO_ constants Jozsef Kadlecsik
2011-09-07 14:45 ` Patrick McHardy
2011-09-07 9:32 ` [PATCH 0/6] ipset patches Pablo Neira Ayuso
2011-09-07 12:04 ` Jozsef Kadlecsik
2011-09-07 14:39 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6782D7.3020101@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.