[Cluster-devel] [PATCH] cman: improve cman/qdisk interactions

[Christine Caulfield <ccaulfie@redhat.com>]

On 07/09/11 19:07, Lon Hohberger wrote:
> Hi,
>
> Good design -- couple of things...
>
> On Wed, Sep 07, 2011 at 03:10:25PM +0200, Fabio M. Di Nitto wrote:
>> - cman: use strdup instead of malloc+strcpy (code is more readable)
>
> * Not really a necessary change, but ok.
>
>> - libcman: perform better error checking in register_quorum_device/update_quorum_device
>>
>> - Allow qdisk to update device name in cman using a new libcman quorum API call
>> - Perform slight better error checking of some update opertaions
>>
>> Resolves: rhbz#735917
>
> * All in all, this seems like a lot of patch for a very tiny problem or
> set of problems in a very narrow use case (renaming quorum device).
>
>


I've chatted with Fabio about this. It's my opinion that this is 
actually the least intrusive way of fixing the problem. The other ways 
involve overloading existing API calls and adding state, which add not 
much less code and also lot more in the way of potential confusions and 
problems.

Chrissie