From: Jerome Marchand <jmarchan@redhat.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Greg KH <greg@kroah.com>, Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] Fix sparse warnings
Date: Thu, 08 Sep 2011 10:17:55 +0200 [thread overview]
Message-ID: <4E687A33.1080401@redhat.com> (raw)
In-Reply-To: <1315445357-14338-2-git-send-email-ngupta@vflare.org>
On 09/08/2011 03:29 AM, Nitin Gupta wrote:
> ---
I'm afraid this patch is missing a description.
Jerome
> drivers/staging/zram/zram_drv.c | 3 ++-
> drivers/staging/zram/zram_drv.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index d70ec1a..03ec5a2 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -684,7 +684,8 @@ fail:
> return ret;
> }
>
> -void zram_slot_free_notify(struct block_device *bdev, unsigned long index)
> +static void zram_slot_free_notify(struct block_device *bdev,
> + unsigned long index)
> {
> struct zram *zram;
>
> diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h
> index abe5221..70ce886 100644
> --- a/drivers/staging/zram/zram_drv.h
> +++ b/drivers/staging/zram/zram_drv.h
> @@ -47,7 +47,7 @@ static const unsigned default_disksize_perc_ram = 25;
> * Pages that compress to size greater than this are stored
> * uncompressed in memory.
> */
> -static const unsigned max_zpage_size = PAGE_SIZE / 4 * 3;
> +static const size_t max_zpage_size = PAGE_SIZE / 4 * 3;
>
> /*
> * NOTE: max_zpage_size must be less than or equal to:
next prev parent reply other threads:[~2011-09-08 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 1:29 [PATCH 0/5 v2] zram: minor features and cleanups Nitin Gupta
2011-09-08 1:29 ` [PATCH 1/5] Fix sparse warnings Nitin Gupta
2011-09-08 8:17 ` Jerome Marchand [this message]
2011-09-08 15:13 ` Nitin Gupta
2011-09-08 17:32 ` Harvey Harrison
2011-09-09 17:00 ` Nitin Gupta
2011-09-09 17:11 ` Dan Carpenter
2011-09-09 17:19 ` [PATCH 1/5 resend] " Nitin Gupta
2011-09-09 20:30 ` Greg KH
2011-09-08 1:29 ` [PATCH 2/5] Kernel config option for number of devices Nitin Gupta
2011-09-08 1:29 ` [PATCH 3/5] Make gobal variables use unique names Nitin Gupta
2011-09-08 1:29 ` [PATCH 4/5] Simplify zram disk resizing interface Nitin Gupta
2011-09-08 1:29 ` [PATCH 5/5] Set initial disksize to some default value Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E687A33.1080401@redhat.com \
--to=jmarchan@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.