All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	johannes@sipsolutions.net
Subject: Re: [PATCH 1/2] mac80211: Don't aggregate rate probe frames in minstrel_ht
Date: Thu, 08 Sep 2011 11:08:17 +0200	[thread overview]
Message-ID: <4E688601.2020505@openwrt.org> (raw)
In-Reply-To: <1315472282-21051-1-git-send-email-helmut.schaa@googlemail.com>

On 2011-09-08 10:58 AM, Helmut Schaa wrote:
> This is already done by rt2x00 and ath9k by checking the
> IEEE80211_TX_CTL_RATE_CTRL_PROBE flag. Instead we can simply do it in
> minstrel_ht.
>
> Signed-off-by: Helmut Schaa<helmut.schaa@googlemail.com>
> ---
>
> Felix, I didn't have a closer look at the ath9k aggregation code but I guess it
> can also be simplified with this change.
>
> Any objections?
Yes, this probably breaks ath9k. IEEE80211_TX_CTL_AMPDU is used to 
indicate that the packet is part of an aggregation session, so ath9k 
only does block ack window tracking for packets that have this flag set.
I think the drivers should continue to check for 
IEEE80211_TX_CTL_RATE_CTRL_PROBE

- Felix

  parent reply	other threads:[~2011-09-08  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08  8:58 [PATCH 1/2] mac80211: Don't aggregate rate probe frames in minstrel_ht Helmut Schaa
2011-09-08  8:58 ` [PATCH 2/2] rt2x00: Remove special case for rate probe frames Helmut Schaa
2011-09-08 12:41   ` Ivo Van Doorn
2011-09-08  9:08 ` Felix Fietkau [this message]
2011-09-08  9:21   ` [PATCH 1/2] mac80211: Don't aggregate rate probe frames in minstrel_ht Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E688601.2020505@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=helmut.schaa@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.