From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.
Date: Thu, 08 Sep 2011 17:01:06 +0200 [thread overview]
Message-ID: <4E68D8B2.2050004@aribaud.net> (raw)
In-Reply-To: <1315396670-22889-1-git-send-email-philip@opensdr.com>
Hi Philip,
Le 07/09/2011 13:57, Philip Balister a ?crit :
> Signed-off-by: Philip Balister<philip@opensdr.com>
> ---
> net/eth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index dbd1e2d..67a8039 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis)
> puts("\nWarning: eth device name has a space!\n");
>
> if (eth_write_hwaddr(dev, "eth", eth_number))
> - puts("Warning: failed to set MAC address\n");
> + puts("\nWarning: failed to set MAC address\n");
I believe warning messages with \n on more than one end are frowned upon.
> eth_number++;
> dev = dev->next;
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-09-08 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 11:57 [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line Philip Balister
2011-09-07 11:57 ` [U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip Philip Balister
2011-09-08 14:21 ` Steve Sakoman
2011-09-08 14:45 ` Enric Balletbò i Serra
2011-09-08 18:50 ` Philip Balister
2011-09-08 19:48 ` Enric Balletbò i Serra
2011-09-07 11:57 ` [U-Boot] [PATCH] overo: Set IEN on GPMC_CLK to support CS's that use synchronous clocking Philip Balister
2011-09-08 15:01 ` Albert ARIBAUD [this message]
2011-09-08 15:04 ` [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line Philip Balister
2011-09-08 16:08 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E68D8B2.2050004@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.