Hi Oleg,

On 09/14/2011 08:16 AM, Oleg Zhurakivskyy wrote:
> ---
>  plugins/mobile-broadband-provider-info.c |  804 ++++++++++++++++++++++++++++++
>  1 files changed, 804 insertions(+), 0 deletions(-)
>  create mode 100644 plugins/mobile-broadband-provider-info.c
> 

After reviewing this patch I got the impression that you were still
making things just way too complicated and not taking full advantage of
the push/pop semantics.  So just for fun I wrote my own version in
plugins/mbpi.[ch] and reworked tools/lookup-apn to use that.  The code
seems to be valgrind clean and can handle duplicate detection, bail out
early, etc.

Can you please take a look and suggest improvements?  Once you think it
is good enough, I'd like you to rewrite this patch series to utilize
mbpi.c parser.

Regards,
-Denis