From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/31] iMX28: Add I2C register definitions
Date: Fri, 09 Sep 2011 07:44:56 +0200 [thread overview]
Message-ID: <4E69A7D8.3020002@denx.de> (raw)
In-Reply-To: <1315514579-19215-12-git-send-email-marek.vasut@gmail.com>
Hello Marek,
Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> ---
> arch/arm/include/asm/arch-mx28/regs-i2c.h | 203 +++++++++++++++++++++++++++++
> 1 files changed, 203 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-mx28/regs-i2c.h
Patch looks good to me, but one minor comment:
> diff --git a/arch/arm/include/asm/arch-mx28/regs-i2c.h b/arch/arm/include/asm/arch-mx28/regs-i2c.h
> new file mode 100644
> index 0000000..1bb20c3
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-mx28/regs-i2c.h
> @@ -0,0 +1,203 @@
> +/*
> + * Freescale i.MX28 I2C Register Definitions
> + *
> + * Copyright (C) 2011 Marek Vasut <marek.vasut@gmail.com>
> + * on behalf of DENX Software Engineering GmbH
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + *
> + */
> +
> +#ifndef __REGS_I2C_H__
> +#define __REGS_I2C_H__
Please use here a more driver specific name, for example __MX28_REGS_I2C__
If you change that, you get my:
Acked-by: Heiko Schocher<hs@denx.de>
(I think, Stefano pick up the complete Patchserie, or?)
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-09-09 5:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 20:42 [U-Boot] [PATCH 00/31] Support for the DENX M28 SoM Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU Marek Vasut
2011-09-09 8:23 ` Stefano Babic
2011-09-09 8:54 ` Heiko Schocher
2011-09-09 10:12 ` Marek Vasut
2011-09-09 10:29 ` Stefano Babic
2011-09-09 10:50 ` Marek Vasut
2011-09-09 11:04 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 02/31] iMX28: Add basic support for DENX M28EVK board Marek Vasut
2011-09-09 7:13 ` Igor Grinberg
2011-09-09 8:26 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 03/31] iMX28: Add support for SSP MMC Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 04/31] M28EVK: Enable MMC support Marek Vasut
2011-09-09 8:28 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 05/31] iMX28: Add pinctrl and ocotp register definitions Marek Vasut
2011-09-09 8:30 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 06/31] FEC: Add support for iMX28 quirks Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 07/31] iMX28: Add CPU-specific FEC ethernet init Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 08/31] M28EVK: Enable FEC0 and FEC1 Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 09/31] iMX28: Add PINMUX control Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 10/31] iMX28: Add RTC register definitions Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 11/31] iMX28: Add I2C " Marek Vasut
2011-09-09 5:44 ` Heiko Schocher [this message]
2011-09-08 20:42 ` [U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver Marek Vasut
2011-09-09 5:45 ` Heiko Schocher
2011-09-09 11:18 ` Marek Vasut
2011-09-09 11:26 ` Stefan Roese
2011-09-09 11:52 ` Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 13/31] M28: Enable I2C, EEPROM and RTC Marek Vasut
2011-09-09 5:45 ` Heiko Schocher
2011-09-08 20:42 ` [U-Boot] [PATCH 14/31] iMX28: Add MMC SPL Marek Vasut
2011-09-09 5:44 ` Chander Kashyap
2011-09-09 7:33 ` Wolfgang Denk
[not found] ` <CANuQgHH_p-_HRf_jBKiPZz=br0+aCyWROWzHDZgV47xWg97aiQ@mail.gmail.com>
2011-09-09 12:49 ` Marek Vasut
2011-09-09 13:14 ` Chander Kashyap
2011-09-10 20:58 ` Marek Vasut
2011-09-10 21:04 ` Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 15/31] M28: Enable " Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 16/31] iMX28: Add GPIO control Marek Vasut
2011-09-09 8:46 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 17/31] M28: Enable use of GPIO configurators Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 18/31] iMX28: Add SPI driver Marek Vasut
2011-09-09 8:51 ` Stefano Babic
2011-09-09 11:50 ` Marek Vasut
2011-09-09 12:34 ` Stefano Babic
2011-09-09 12:50 ` Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 19/31] M28EVK: Enable SPI and SPI flash Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 20/31] iMX28: Add APBH DMA driver Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 21/31] iMX28: Add BCH and GPMI register definitions Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 22/31] iMX28: Add GPMI NAND driver Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 23/31] M28: Enable NAND Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 24/31] iMX28: Add driver for internal RTC Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 25/31] M28: Enable the internal RTC instead of the M41T62 Marek Vasut
2011-09-09 12:45 ` Stefano Babic
2011-09-09 12:51 ` Marek Vasut
2011-09-09 12:55 ` Stefano Babic
2011-09-08 20:42 ` [U-Boot] [PATCH 26/31] M28: Enable UBI and UBIFS Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 27/31] M28: Save environment in NAND Marek Vasut
2011-09-16 19:15 ` Scott Wood
2011-09-17 8:20 ` Marek Vasut
2011-09-19 17:54 ` Scott Wood
2011-09-17 7:10 ` Fabio Estevam
2011-09-08 20:42 ` [U-Boot] [PATCH 28/31] iMX28: Add image header generator tool Marek Vasut
2011-09-09 8:58 ` Stefano Babic
2011-09-09 11:51 ` Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 29/31] M28: Add NAND update scripts Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 30/31] i.MX28: Add u-boot.sb target to Makefile Marek Vasut
2011-09-08 20:42 ` [U-Boot] [PATCH 31/31] M28: Add doc/README.m28 documentation Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E69A7D8.3020002@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.