From: Michal Simek <monstr@monstr.eu>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added sync method support for DMA and made refinements (Take II)
Date: Fri, 09 Sep 2011 11:19:38 +0200 [thread overview]
Message-ID: <4E69DA2A.8070707@monstr.eu> (raw)
In-Reply-To: <1314976538-21052-1-git-send-email-eli.billauer@gmail.com>
Eli Billauer wrote:
> Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Missing description. + add "microblaze: " prefix to subject.
I have looked at the patch again and I would prefer
to separate it to 3 patches.
1. Move __dma_sync to dma-mapping.h + fix parameters.
2. Introduce new sync operations
3. The rest of changes in dma code.
I have no problem to apply patch 1 and 2.
If you show me bug you see with patch 3, I will test it and keep in my repo for a while.
As I wrote in my previous post, I am open to add your comment to dma code
that flush will be safer to use but slower if cache lines are dirty but I don't like
to cache the code without real problem.
In any case, if you show me, on program/driver/etc that the problem is in invalidation
I will apply it without no problem.
Thanks for your patches,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2011-09-09 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 9:31 [PATCH] arch/microblaze: Added sync method support for DMA and made refinements Eli Billauer
2011-09-02 12:32 ` Michal Simek
2011-09-02 15:12 ` Eli Billauer
2011-09-09 9:16 ` Michal Simek
2011-09-02 15:15 ` [PATCH] Added sync method support for DMA and made refinements (Take II) Eli Billauer
2011-09-09 9:19 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E69DA2A.8070707@monstr.eu \
--to=monstr@monstr.eu \
--cc=eli.billauer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.