From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1z7K-0002mL-4i
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:19:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1z7I-0006F2-RO
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:19:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1z7I-0006Ey-J7
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:19:28 -0400
Message-ID: <4E69F6ED.9050906@redhat.com>
Date: Fri, 09 Sep 2011 13:22:21 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1315511055-6963-1-git-send-email-weil@mail.berlios.de>
	<4E69D945.4090404@redhat.com>
	<3BE4ED96-E111-4D77-9D0A-8D330C0C3F55@suse.de>
In-Reply-To: <3BE4ED96-E111-4D77-9D0A-8D330C0C3F55@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Am 09.09.2011 11:43, schrieb Alexander Graf:
> 
> On 09.09.2011, at 11:15, Kevin Wolf wrote:
> 
>> Am 08.09.2011 21:44, schrieb Stefan Weil:
>>> Member variable is_read is written, but never read
>>> (contrary to its name).
>>
>> Nice commit message :-)
>>
>>> Kevin Wolf <kwolf@redhat.com>
>>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>> ---
>>> hw/ide/ahci.c |    2 --
>>> hw/ide/ahci.h |    1 -
>>> 2 files changed, 0 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>>> index f4fa154..a8659cf 100644
>>> --- a/hw/ide/ahci.c
>>> +++ b/hw/ide/ahci.c
>>> @@ -754,7 +754,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>>>         case READ_FPDMA_QUEUED:
>>>             DPRINTF(port, "NCQ reading %d sectors from LBA %ld, tag %d\n",
>>>                     ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>>> -            ncq_tfs->is_read = 1;
>>>
>>>             DPRINTF(port, "tag %d aio read %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>>
>>> @@ -768,7 +767,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>>>         case WRITE_FPDMA_QUEUED:
>>>             DPRINTF(port, "NCQ writing %d sectors to LBA %ld, tag %d\n",
>>>                     ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>>> -            ncq_tfs->is_read = 0;
>>>
>>>             DPRINTF(port, "tag %d aio write %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>>
>>> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
>>> index 3c29d93..5de986c 100644
>>> --- a/hw/ide/ahci.h
>>> +++ b/hw/ide/ahci.h
>>> @@ -259,7 +259,6 @@ typedef struct NCQTransferState {
>>>     BlockDriverAIOCB *aiocb;
>>>     QEMUSGList sglist;
>>>     BlockAcctCookie acct;
>>> -    int is_read;
>>>     uint16_t sector_count;
>>>     uint64_t lba;
>>>     uint8_t tag;
>>
>> Alex, any specific reason you introduced it for? Is it unnecessary or is
>> it a bug that it has no user?
> 
> This is a leftover from before the code went upstream. It can easily go away :)

Great, thanks. Applied to the block branch.

Kevin