From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx31pdk: Remove board config.mk file
Date: Fri, 09 Sep 2011 18:04:12 +0200 [thread overview]
Message-ID: <4E6A38FC.5040000@denx.de> (raw)
In-Reply-To: <1315582734-20137-1-git-send-email-fabio.estevam@freescale.com>
On 09/09/2011 05:38 PM, Fabio Estevam wrote:
> config.mk files should not be used in board level directory.
>
> Remove this file and also use CONFIG_SYS_TEXT_BASE_SPL, which is the
> correct base address for the SPL case.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Hi Fabio,
> ---
> board/freescale/mx31pdk/config.mk | 5 -----
> nand_spl/board/freescale/mx31pdk/Makefile | 3 ++-
> 2 files changed, 2 insertions(+), 6 deletions(-)
> delete mode 100644 board/freescale/mx31pdk/config.mk
>
> diff --git a/board/freescale/mx31pdk/config.mk b/board/freescale/mx31pdk/config.mk
> deleted file mode 100644
> index de2c642..0000000
> --- a/board/freescale/mx31pdk/config.mk
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -ifdef CONFIG_NAND_SPL
> -CONFIG_SYS_TEXT_BASE = 0x87ec0000
> -else
> -CONFIG_SYS_TEXT_BASE = 0x87f00000
> -endif
> diff --git a/nand_spl/board/freescale/mx31pdk/Makefile b/nand_spl/board/freescale/mx31pdk/Makefile
> index e6ec10a..a5dc0ce 100644
> --- a/nand_spl/board/freescale/mx31pdk/Makefile
> +++ b/nand_spl/board/freescale/mx31pdk/Makefile
> @@ -1,4 +1,5 @@
> CONFIG_NAND_SPL = y
> +CONFIG_SYS_TEXT_BASE_SPL := 0x87ec0000
>
> include $(TOPDIR)/config.mk
> include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
> @@ -6,7 +7,7 @@ include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
> nandobj := $(OBJTREE)/nand_spl/
>
> LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds
> -LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \
> +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) $(LDFLAGS) \
> $(LDFLAGS_FINAL)
> AFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
> CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
It sounds good. I'll wait only a couple of days for comments, then I
will merge into u-boot-imx.
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-09-09 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 15:38 [U-Boot] [PATCH] mx31pdk: Remove board config.mk file Fabio Estevam
2011-09-09 16:04 ` Stefano Babic [this message]
2011-09-12 14:08 ` Fabio Estevam
2011-09-09 21:56 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6A38FC.5040000@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.