All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] balloon: Disassociate handlers from balloon device on unplug
Date: Fri, 09 Sep 2011 13:35:31 -0500	[thread overview]
Message-ID: <4E6A5C73.6050206@codemonkey.ws> (raw)
In-Reply-To: <7d472e560b452ffba3f75ae364c2db709f7fab2d.1315558826.git.amit.shah@redhat.com>

On 09/09/2011 04:00 AM, Amit Shah wrote:
> When a balloon device gets unplugged, allow the balloon handlers to be
> freed.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>

Applied all.  Thanks.

Regards,

Anthony Liguori

> ---
>   balloon.c |   10 ++++++++++
>   balloon.h |    1 +
>   2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/balloon.c b/balloon.c
> index f56fdc1..a2133db 100644
> --- a/balloon.c
> +++ b/balloon.c
> @@ -52,6 +52,16 @@ int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
>       return 0;
>   }
>
> +void qemu_remove_balloon_handler(void *opaque)
> +{
> +    if (balloon_opaque != opaque) {
> +        return;
> +    }
> +    balloon_event_fn = NULL;
> +    balloon_stat_fn = NULL;
> +    balloon_opaque = NULL;
> +}
> +
>   static int qemu_balloon(ram_addr_t target)
>   {
>       if (!balloon_event_fn) {
> diff --git a/balloon.h b/balloon.h
> index 3df14e6..f59e288 100644
> --- a/balloon.h
> +++ b/balloon.h
> @@ -22,6 +22,7 @@ typedef void (QEMUBalloonStatus)(void *opaque, MonitorCompletion cb,
>
>   int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
>   			     QEMUBalloonStatus *stat_func, void *opaque);
> +void qemu_remove_balloon_handler(void *opaque);
>
>   void monitor_print_balloon(Monitor *mon, const QObject *data);
>   int do_info_balloon(Monitor *mon, MonitorCompletion cb, void *opaque);

      parent reply	other threads:[~2011-09-09 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09  9:00 [Qemu-devel] [PATCH 1/2] balloon: Disassociate handlers from balloon device on unplug Amit Shah
2011-09-09  9:00 ` [Qemu-devel] [PATCH 2/2] virtio-balloon: Disassociate from the balloon handlers " Amit Shah
2011-09-09 18:35 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6A5C73.6050206@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.