Re: [PATCH] arch/x86/kernel/kprobes.c: quiet sprase noise about external linkage

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2011/09/10 7:59), H Hartley Sweeten wrote:
> The function arch_unoptimize_kprobes is already declared extern in
> <linux/kprobes.h>. The actual function should not be marked as extern.
> This quiets the following sparse noise:
> 
> warning: function 'arch_unoptimize_kprobes' with external linkage has definition

Right, there is no reason to mark it extern.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thank you,

> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Namhyung Kim <namhyung@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> 
> ---
> 
> diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
> index f1a6244..e8d5903 100644
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -1483,8 +1483,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm,
>   * Recover original instructions and breakpoints from relative jumps.
>   * Caller must call with locking kprobe_mutex.
>   */
> -extern void arch_unoptimize_kprobes(struct list_head *oplist,
> -				    struct list_head *done_list)
> +void arch_unoptimize_kprobes(struct list_head *oplist,
> +			     struct list_head *done_list)
>  {
>  	struct optimized_kprobe *op, *tmp;
>  	int c = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com