From: Thomas Goirand <thomas@goirand.fr>
To: mlmmj@mlmmj.org
Subject: Re: [mlmmj] Fwd: [mlmmj commits] Implement new list text naming scheme
Date: Sat, 10 Sep 2011 16:10:25 +0000 [thread overview]
Message-ID: <4E6B8BF1.402@goirand.fr> (raw)
In-Reply-To: <4E6AD8F6.2070408@yahoo.com.au>
On 09/10/2011 11:26 AM, Ben Schmidt wrote:
> Could a C coder please review this changeset for me? There's nothing too
> technical in it so any proficient C coder should be able to review it
> adequately. It's only had a very small amount of testing so far, but
> seems to work.
>
> http://mlmmj.org/hg/mlmmj/rev/c3ee2bfaeb02
>
> (After this, the substitution mechanism needs to be reworked, which will
> need a code review, and then the new list texts can be tested. Then I
> will just fix a few easy and high priority bugs before releasing a beta.
> Other bug fixes and enhancements can wait for another release which I
> expect will follow much more quickly.)
>
> Ben.
I had a quick look, and as you said, there's not much in this patch that
could be seen as suspicious. Few functional tests should be enough.
Thomas
next prev parent reply other threads:[~2011-09-10 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 3:26 [mlmmj] Fwd: [mlmmj commits] Implement new list text naming scheme Ben Schmidt
2011-09-10 16:10 ` Thomas Goirand [this message]
2011-09-10 21:41 ` Ben Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6B8BF1.402@goirand.fr \
--to=thomas@goirand.fr \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.