From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Schmidt Date: Sat, 10 Sep 2011 21:41:17 +0000 Subject: Re: [mlmmj] Fwd: [mlmmj commits] Implement new list text naming scheme Message-Id: <4E6BD97D.2070704@yahoo.com.au> List-Id: References: <4E6AD8F6.2070408@yahoo.com.au> In-Reply-To: <4E6AD8F6.2070408@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: mlmmj@mlmmj.org Thank you, Thomas. That was a very quick reply. Ben. On 11/09/11 2:10 AM, Thomas Goirand wrote: > On 09/10/2011 11:26 AM, Ben Schmidt wrote: >> Could a C coder please review this changeset for me? There's nothing too >> technical in it so any proficient C coder should be able to review it >> adequately. It's only had a very small amount of testing so far, but >> seems to work. >> >> http://mlmmj.org/hg/mlmmj/rev/c3ee2bfaeb02 >> >> (After this, the substitution mechanism needs to be reworked, which will >> need a code review, and then the new list texts can be tested. Then I >> will just fix a few easy and high priority bugs before releasing a beta. >> Other bug fixes and enhancements can wait for another release which I >> expect will follow much more quickly.) >> >> Ben. > > I had a quick look, and as you said, there's not much in this patch that > could be seen as suspicious. Few functional tests should be enough. > > Thomas > > >