All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Haley <brian.haley@hp.com>
To: Paul Stewart <pstew@chromium.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] ipv6: Create module parameter for use_tempaddr
Date: Mon, 12 Sep 2011 15:51:45 -0400	[thread overview]
Message-ID: <4E6E62D1.8010108@hp.com> (raw)
In-Reply-To: <CAMcMvsja6hmHj3-+vCYLnXXBbGznK9EJbx+mkBgT8gR6iwRoWg@mail.gmail.com>

On 09/12/2011 12:37 PM, Paul Stewart wrote:
> Hello, folks.  I've been trying to upstream (or open a discussion on)
> adding a module parameter to enable IPv6 address privacy as a module
> parameter.  The author listed for if_inet6.c is not a bouncing email
> address.  Does anyone else have a suggestion for where to get this
> change vetted?  I'm now CC'ing the author and reviewer of the last
> module parameter change for ipv6.

I think David would just tell you to be patient, your patch is listed in
patchwork, http://patchwork.ozlabs.org/project/netdev/list/ , and git.kernel.org
is still down...

>>>  static int disable_ipv6_mod = 0;
>>> @@ -89,6 +92,11 @@ MODULE_PARM_DESC(disable_ipv6, "Disable IPv6 on all interfaces");
>>>  module_param_named(autoconf, ipv6_defaults.autoconf, int, 0444);
>>>  MODULE_PARM_DESC(autoconf, "Enable IPv6 address autoconfiguration on all interfaces");
>>>
>>> +#ifdef CONFIG_IPV6_PRIVACY
>>> +module_param_named(use_tempaddr, ipv6_defaults.use_tempaddr, int, 0444);
>>> +MODULE_PARM_DESC(use_tempaddr, "Enable IPv6 address privacy for autoconfiguration by default");
>>> +#endif

I don't know if you want this under an #ifdef, since that could fail a module
load on certain kernel builds - people might want to put the same entry in a
conf file whether the kernel supports it or not (if it's accepted).

And you failed to update Documentation/networking/ipv6.txt

-Brian

  reply	other threads:[~2011-09-12 19:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01  6:03 [PATCH] ipv6: Create module parameter for use_tempaddr Paul Stewart
2011-09-06 23:56 ` Paul Stewart
2011-09-12 16:37   ` Paul Stewart
2011-09-12 19:51     ` Brian Haley [this message]
2011-09-01  6:03       ` [PATCHv2] " Paul Stewart
2011-09-13 18:39         ` Bjørn Mork
2011-09-13 19:56           ` Paul Stewart
2011-09-13 20:04             ` David Miller
2011-09-12 21:21       ` [PATCH] " Paul Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6E62D1.8010108@hp.com \
    --to=brian.haley@hp.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pstew@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.