From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Brent Taylor <btaylor1@motorolasolutions.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: ATH6KL lockup during init
Date: Tue, 13 Sep 2011 09:29:43 +0300 [thread overview]
Message-ID: <4E6EF857.4080303@qca.qualcomm.com> (raw)
In-Reply-To: <loom.20110804T145012-465@post.gmane.org>
Hi Brent,
On 08/04/2011 03:55 PM, Brent Taylor wrote:
> Kalle Valo <kvalo@...> writes:
>
>>
>> Brent Taylor <btaylor1@...> writes:
>>
>>> Fixed ... realized that I was using the wrong firmware images. I was
>>> using an older image from AR6K_FW.3.0_RC.233.
>>
>> Good that your issue was solved and thanks for letting us now. But
>> nevertheless the driver should not lockup in there's a problem with
>> firmware, ath6kl is definitely buggy here.
>
> My lockup (due to wrong firmware) was caused by the function
> ath6kl_bmi_get_lkahd in bmi.c. The function was called with the parameter
> "need_timeout = false". This causes the while loop to wait for a response from
> the chip. Since the wrong firmware image was used, the chip will never respond.
Thanks for the analysis. Yesterday I submitted a patch for review which
will fix this.
> Is it possible for the ath6kl driver to somehow read the firmware version from
> the firmware file before sending it to the chip?
Not right now. But in the new firmware image format (for which I also
sent patches yesterday) we can do that. You can even check the firmware
just with the strings command.
Thank you for the feedback, I appreciate it.
Kalle
prev parent reply other threads:[~2011-09-13 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 15:43 ATH6KL lockup during init Brent Taylor
2011-07-27 5:19 ` Vasanthakumar Thiagarajan
2011-07-27 12:51 ` Brent Taylor
2011-08-02 5:59 ` Kalle Valo
2011-08-04 12:55 ` Brent Taylor
2011-09-13 6:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6EF857.4080303@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=btaylor1@motorolasolutions.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.