From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3O4N-00014o-8U
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 04:10:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3O4L-0001fl-RG
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 04:10:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3O4L-0001fh-Gw
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 04:10:13 -0400
Message-ID: <4E6F0FDD.1080809@redhat.com>
Date: Tue, 13 Sep 2011 11:10:05 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1314033132.git.jan.kiszka@siemens.com>
	<3d9d904a1e4939a147f8954c9e0d4cdaf3d44c31.1314033132.git.jan.kiszka@siemens.com>
	<4E6E2329.9050109@suse.de>
	<CAAu8pHv6rCZBcPx18JqDME3tGwWQ4vnuPDnbNGTPFQopCJK=BQ@mail.gmail.com>
	<A1AAE0A7-6462-4E66-A0C8-2B38EC60B380@suse.de>
	<4E6F0B69.5020301@redhat.com>
	<5C93915C-6DCE-4DC4-8EF6-31F5DDE42D03@suse.de>
In-Reply-To: <5C93915C-6DCE-4DC4-8EF6-31F5DDE42D03@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty
 logging in chain 4 memory access mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, andreas.faerber@web.de, Gerd Hoffmann <kraxel@redhat.com>

On 09/13/2011 10:54 AM, Alexander Graf wrote:
> >>
> >>  Yeah, usually the ISA bus is behind an ISA-PCI bridge, so it should inherit the offset from its parent. Or do you mean something different?
> >>
> >
> >  He means that isa_mem_base should go away; instead isa_address_space() should be a subregion at offset 0x80000000.
>
> So we are talking about the same thing. Logically speaking, ISA devices are behind the ISA-PCI bridge, so the parent would be the bridge, right?


Right.  system_memory -> pci_address_space() -> isa_address_space() -> 
various vga areas.

>
> >  Which vga variant are you using?
>
> This is stdvga.
>
>

Don't see the call to vga_init() in that path (this is what passes 
isa_address_space() to the vga core).

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.