From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] UBI problems on current u-boot
Date: Tue, 13 Sep 2011 10:32:34 +0200 [thread overview]
Message-ID: <4E6F1522.4040201@keymile.com> (raw)
In-Reply-To: <201109130939.45132.sr@denx.de>
Hi Stefan,
On 09/13/2011 09:39 AM, Stefan Roese wrote:
> Hi Holger,
>
> On Monday 12 September 2011 19:16:33 Holger Brunck wrote:
>> I have seen in mainline kernel this fix in the ubi layer:
>>
>> commit b86a2c56e512f46d140a4bcb4e35e8a7d4a99a4b
>> Author: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>> Date: Sun May 24 14:13:34 2009 +0300
>>
>> UBI: do not switch to R/O mode on read errors
>>
>> This patch improves UBI errors handling. ATM UBI switches to
>> R/O mode when the WL worker fails to read the source PEB.
>> This means that the upper layers (e.g., UBIFS) has no
>> chances to unmap the erroneous PEB and fix the error.
>> This patch changes this behaviour and makes UBI put PEBs
>> like this into a separate RB-tree, thus preventing the
>> WL worker from hitting the same read errors again and
>> again.
>>
>> [...]
>>
>> And this sounds like the problem I see in u-boot.
>
> Yes, very likely.
>
>> But this patch is not
>> easy to port onto u-boot because previously undergoing changes in the
>> kernels ubi layer...
>
> Correct. UBI has undergone many changes since the integration into U-Boot back
> in the end of 2008 (nearly 3 years ago now). Perhaps the best would be to re-
> synch with the latest Linux UBI version. But this sounds like quite a lot of
> work as well...
>
if found a way to port only this patch. But I had to do some changes to it.
E.g. exchange the constants for errors with numeric values as present in u-boots
ubi version. And remove setting of the constants (MOVE_TARGET_RD_ERR) values
which are not evaluated in u-boots ubi version. This fixes my problem. Should I
post this patch?
Regards
Holger
next prev parent reply other threads:[~2011-09-13 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 13:32 [U-Boot] UBI problems on current u-bo Holger Brunck
2011-09-05 14:37 ` Stefan Roese
2011-09-05 15:46 ` Holger Brunck
2011-09-05 15:57 ` [U-Boot] UBI problems on current u-boot Holger Brunck
2011-09-12 17:16 ` Holger Brunck
2011-09-13 7:39 ` Stefan Roese
2011-09-13 8:32 ` Holger Brunck [this message]
2011-09-13 8:37 ` Stefan Roese
2011-09-13 15:31 ` Holger Brunck
2011-09-21 9:06 ` Holger Brunck
2012-09-28 16:50 ` Charles Hardin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6F1522.4040201@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.