From: Sergei Shtylyov <sshtylyov@mvista.com>
To: post@pfrst.de
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Impact video driver for SGI Indigo2
Date: Tue, 13 Sep 2011 14:38:38 +0400 [thread overview]
Message-ID: <4E6F32AE.3040007@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1109131101530.4143@Indigo2.Peter>
Hello.
On 13-09-2011 13:39, peter fuerst wrote:
>> Date: Mon, 12 Sep 2011 13:56:36 +0400
>> From: Sergei Shtylyov <sshtylyov@mvista.com>
>> To: post@pfrst.de
>> Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
>> attilio.fiandrotti@gmail.com
>> Subject: Re: [PATCH] Impact video driver for SGI Indigo2
>> ...
>>> framebuffer device. Without the support of PCI & AGP.
>> It looks like the patch is spoiled as I'm seeing two spaces at the start
>> of line when looking at the message source.
> hmmm, that's a strange problem. The two spaces are not in the diff-file
> read into the eMail and are not displayed by the MUA (pine 4.64). But
Indeed, they're not displayed (though due to "format=flowed" the patch is
not diasplyed correctly for me anyway).
> indeed, where's a leading space in the diff, there's an additional space
> inserted into the eMail-body. Have to find out the best way to suppress
> this behaviour...
>>>
>>> ...
>> There are alos empty lines after each file in the patch -- which
>> shouldn't be there.
> These were intended for readability (reviewability :), but i can remove
> them easily (of course).
These will prevent the patch from applying, AFAIK.
>>> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
>>> ...
>> The above should be a part of the driver patch, as you can't add Makefile
>> targets fow which no source files exist yet.
> Do you suggest to submit the ip22-setup.c-, impact.h-, impact.c-parts
> alone in a first patch and then,
No, I suggest putting drivers/video/impact.* and drivers/video/*Kconfig
and drivers/video/Makefile in one patch and leaving ip22-setup.c in another
one -- the driver should be separate from the platform code IMO. The defconfig
change should also be a patch of it's own, IMO.
> in a separate follow-up patch, the
> Kconfig- and Makefile-parts, or just to reorder the parts in this single
> patch?
No, not reorder.
> with kind regards
> peter
WBR, Sergei
next prev parent reply other threads:[~2011-09-13 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 9:39 [PATCH] Impact video driver for SGI Indigo2 peter fuerst
2011-09-13 10:03 ` Jayachandran C.
2011-09-13 10:38 ` Sergei Shtylyov [this message]
2011-09-13 12:20 ` peter fuerst
2011-09-13 13:03 ` peter fuerst
-- strict thread matches above, loose matches on Subject: below --
2011-09-11 11:14 peter fuerst
2011-09-12 9:56 ` Sergei Shtylyov
2011-09-13 12:43 ` Joshua Kinard
2011-09-14 14:50 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6F32AE.3040007@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=post@pfrst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.