From: Paolo Bonzini <pbonzini@redhat.com>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hid: vmstat fix
Date: Wed, 14 Sep 2011 09:59:23 +0200 [thread overview]
Message-ID: <4E705EDB.9060702@redhat.com> (raw)
In-Reply-To: <CAETRQWnGTTLDD6o-7+hwAN6mvdKh1R22mgNtdgfypJMf_dciLA@mail.gmail.com>
On 09/14/2011 09:40 AM, TeLeMan wrote:
>>> >>
>>> >> The commit "usb/hid: add hid_pointer_activate, use it" used
>>> >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so
>>> >> mouse_grabbed should be added into vmstat.
>> >
>> > Does this fix a bug? qemu_activate_mouse_event_handler is meant to be
>> > called once per execution of the VM, it is not guest state.
> Yes, this patch fixes the usb mouse not be working after loadvm in the
> guest windows.
I'm wondering if, with your patch, Windows is actually using the PS/2
mouse after loadvm... If that is the case, perhaps instead you can move
if (hs->kind == HID_MOUSE || hs->kind == HID_TABLET) {
hid_pointer_activate(hs);
}
from hw/usb-hid.c to hid_set_next_idle, which is called at post-load time.
Paolo
next prev parent reply other threads:[~2011-09-14 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 3:03 [Qemu-devel] [PATCH] hid: vmstat fix TeLeMan
2011-09-14 7:15 ` Paolo Bonzini
2011-09-14 7:40 ` TeLeMan
2011-09-14 7:59 ` Paolo Bonzini [this message]
2011-09-15 13:40 ` Gerd Hoffmann
2011-09-19 3:56 ` TeLeMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E705EDB.9060702@redhat.com \
--to=pbonzini@redhat.com \
--cc=geleman@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.