From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Arun Raghavan <arun.raghavan@collabora.co.uk>
Subject: Re: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control, name
Date: Wed, 14 Sep 2011 13:38:58 +0200 [thread overview]
Message-ID: <4E709252.5060206@canonical.com> (raw)
In-Reply-To: <s5hvcsvs6em.wl%tiwai@suse.de>
On 09/14/2011 01:35 PM, Takashi Iwai wrote:
> At Wed, 14 Sep 2011 13:25:55 +0200,
> David Henningsson wrote:
>>
>> > From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
>> From: David Henningsson<david.henningsson@canonical.com>
>> Date: Wed, 14 Sep 2011 13:22:54 +0200
>> Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
>> name
>>
>> Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
>>
>> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
>> ---
>> sound/pci/hda/patch_cirrus.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
>> index d6c93d9..c45f3e6 100644
>> --- a/sound/pci/hda/patch_cirrus.c
>> +++ b/sound/pci/hda/patch_cirrus.c
>> @@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
>> int index, unsigned int pval, int dir,
>> struct snd_kcontrol **kctlp)
>> {
>> - char tmp[32];
>> + char tmp[44];
>> struct snd_kcontrol_new knew =
>> HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
>> knew.private_value = pval;
>
> Hm, it doesn't match with the patch description...
Sorry, can you clarify what I have to do to get this patch committed?
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
next prev parent reply other threads:[~2011-09-14 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 11:25 [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control, name David Henningsson
2011-09-14 11:35 ` Takashi Iwai
2011-09-14 11:38 ` David Henningsson [this message]
2011-09-14 11:41 ` Takashi Iwai
2011-09-14 11:42 ` [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control name David Henningsson
2011-09-14 12:05 ` Takashi Iwai
2011-09-14 12:02 ` [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control, name Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E709252.5060206@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=arun.raghavan@collabora.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.