Re: [PATCH] eglibc-2.9: allow building with newer GNU make

[Steffen Sledz <sledz@dresearch-fe.de>]

On 14.09.2011 16:36, Paul Menzel wrote:
>>>> The patch header is missing [1].
>>>
>>> Hmmm? After reading [1] i could not find what exactly is missing.
>>
>> Does the guidelines require that the patch files itself (make-3.82.patch in this case) need a header (in addition to the commit comment)?
> 
> Yes, that is correct.

It would be very helpful if [1] could be modified in a way that makes clear that it talk about to separate things: the commit message *and* the patch header.

This was totally unclear for me after reading it.

>> If yes, how do i create such a header? Normally i create the patch with "diff -Nurd".
>>
>> If no, please enlighten me what is required?
> 
> You can add any text to a diff file above a `---` I think. `patch` can
> handle that. But there should be some example in the repositories.

OK, i'll create a new version of the commit.

Steffen

[1] http://openembedded.org/index.php?title=Commit_Patch_Message_Guidelines

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058