Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()

[Richard Henderson <rth@twiddle.net>]

On 09/12/2011 03:03 AM, Peter Maydell wrote:
> Remove the unused function tcg_out_addi() from the ARM TCG backend;
> this fixes a compilation failure on ARM hosts with newer gcc.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Richard Henderson <rth@twiddle.net>

> ---
> A previous patch from Richard Henderson for this compile failure:
>  http://patchwork.ozlabs.org/patch/110400/
> was rejected, so here's another go. This simply removes the unused function,
> in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and
> c24a9c6ef94.
> 
> If this is accepted I can do the equivalent patches for tcg/ia64 and tcg/s390
> (although those don't cause compile failures because the unused function
> happens to be marked 'inline'.)

If we ever need this function again, we can revive it from git.
I'm in favor of deleting all of these functions.


r~