From: Timur Tabi <timur@freescale.com>
To: Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver
Date: Wed, 14 Sep 2011 16:51:24 -0500 [thread overview]
Message-ID: <4E7121DC.908@freescale.com> (raw)
In-Reply-To: <1316003710.3229.14.camel@odin>
Liam Girdwood wrote:
> Sounds like we also need this for the other codec drivers too at some
> point.
Yes, but I can only test *this* codec on a big-endian system. :-)
>> /* Set word length */
>> - switch (params_format(params)) {
>> - case SNDRV_PCM_FORMAT_S16_LE:
>> + i = snd_pcm_format_width(params_format(params));
>> + switch (i) {
>
> Just a minor nitpick. I would not have used the intermediate 'i' here
> and would have just embedded the snd_pcm call within the switch(). I
> guess it may not fit the line width though.
'i' is used twice:
switch (i) {
and
dev_err(codec->dev, "Unsupported sample size: %i\n", i);
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-09-14 21:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 17:59 [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver Timur Tabi
2011-09-13 17:59 ` [PATCH 2/3] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-14 12:36 ` Liam Girdwood
2011-09-15 10:24 ` Mark Brown
2011-09-15 15:08 ` Timur Tabi
2011-09-15 22:38 ` Mark Brown
2011-09-15 23:06 ` Tabi Timur-B04825
2011-09-15 23:49 ` Mark Brown
2011-09-16 13:48 ` Timur Tabi
2011-09-17 13:04 ` Mark Brown
2011-09-13 17:59 ` [PATCH 3/3] ASoC: improve asynchronous mode support in the fsl_ssi driver Timur Tabi
2011-09-14 12:37 ` Liam Girdwood
2011-09-15 23:06 ` Mark Brown
2011-09-15 23:49 ` Mark Brown
2011-09-14 12:35 ` [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver Liam Girdwood
2011-09-14 21:51 ` Timur Tabi [this message]
2011-09-15 10:26 ` Mark Brown
2011-09-15 11:28 ` Tabi Timur-B04825
2011-09-15 13:21 ` Mark Brown
2011-09-15 15:16 ` Timur Tabi
2011-09-15 23:38 ` Mark Brown
2011-09-16 9:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7121DC.908@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.