From: Nigel Cunningham <nigel@tuxonice.net>
To: TuxOnIce users' list <tuxonice-users@lists.tuxonice.net>
Cc: linux-raid@vger.kernel.org, Neil Brown <neilb@suse.de>
Subject: Re: Repeatable md OOPS on suspend, 2.6.39.4 and 3.0.3
Date: Thu, 15 Sep 2011 09:32:10 +1000 [thread overview]
Message-ID: <4E71397A.9060708@tuxonice.net> (raw)
In-Reply-To: <87mxed7u3s.fsf_-_@spindle.srvr.nix>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Hi.
Please try/review the attached patch.
The problem is that TuxOnIce adds a BUG_ON() to catch non-TuxOnIce I/O
during hibernation, as a method of seeking to stop on-disk data getting
corrupted by the writing of data that has potentially been overwritten
by the atomic copy.
Stopping the md devices from being marked readonly is the right thing to
do - if we don't resume, we want recovery to be run. If we do resume,
they should still be in the pre-hibernate state.
Regards,
Nigel
[-- Attachment #2: md-reboot-mark-readonly.patch --]
[-- Type: text/x-diff, Size: 478 bytes --]
diff --git a/drivers/md/md.c b/drivers/md/md.c
index af0e52c..25af0a8 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8056,7 +8056,7 @@ static int md_notify_reboot(struct notifier_block *this,
struct list_head *tmp;
mddev_t *mddev;
- if ((code == SYS_DOWN) || (code == SYS_HALT) || (code == SYS_POWER_OFF)) {
+ if (((code == SYS_DOWN) || (code == SYS_HALT) || (code == SYS_POWER_OFF)) && !freezer_state) {
printk(KERN_INFO "md: stopping all md devices.\n");
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
TuxOnIce-users mailing list
TuxOnIce-users@lists.tuxonice.net
http://lists.tuxonice.net/listinfo/tuxonice-users
next prev parent reply other threads:[~2011-09-14 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALxPEfw-XdcosHemovkxj9aOwaYxUaQ6dj=yMaKCmoy2vkkUkg@mail.gmail.com>
[not found] ` <loom.20110901T032036-733@post.gmane.org>
[not found] ` <CALxPEfwJ99bvmSXkqSKutAYbcD9OLcyMcKQQO6G+Yxi9RQ1DFA@mail.gmail.com>
[not found] ` <CALxPEfyQrwWh1AWY-fwwCeMzDEeK390Eof9PwrsN6C11Wnt9=A@mail.gmail.com>
[not found] ` <loom.20110906T201030-97@post.gmane.org>
2011-09-09 12:55 ` Repeatable md OOPS on suspend, 2.6.39.4 and 3.0.3 Nix
2011-09-14 23:32 ` Nigel Cunningham [this message]
2011-09-15 3:31 ` [TuxOnIce-users] " NeilBrown
2011-09-15 4:18 ` Nigel Cunningham
2011-09-15 5:38 ` Nix
2011-09-15 5:34 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71397A.9060708@tuxonice.net \
--to=nigel@tuxonice.net \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tuxonice-users@lists.tuxonice.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.